Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(alicloud): clouddriver-alicloud supports deploying cluster #5682

Closed
wants to merge 1 commit into from
Closed

feat(alicloud): clouddriver-alicloud supports deploying cluster #5682

wants to merge 1 commit into from

Conversation

ziggyw
Copy link

@ziggyw ziggyw commented Apr 8, 2022

  • Supports Cluster view
  • Supports Instance、Instance Type、Image view
  • Enable Alibaba cloud

Copy link
Member

@mattgogerly mattgogerly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Going to take a few sittings to get through this.

Please run spotless:apply to fix the formatting of the code.

@ziggyw
Copy link
Author

ziggyw commented Apr 11, 2022

Hi @mattgogerly Thanks for you review. been updated .

@ziggyw
Copy link
Author

ziggyw commented Apr 14, 2022

HI @mattgogerly Can you merge this PR? Please let me know if there is any issue. Thanks in advance.

@ziggyw ziggyw requested a review from mattgogerly April 15, 2022 01:31
@mattgogerly
Copy link
Member

Hi, the TOC are discussing this as it's a new provider, so I'm holding off reviewing for now.

cc @spinnaker/toc @spinnaker/sc

Copy link
Contributor

@dbyron-sf dbyron-sf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi there. In an earlier alicloud PR there was a comment about the steps to take for adding a new cloud provider. And then there was spinnaker/governance#15, but apparently those steps didn't actually happen. The story continues with spinnaker/governance#122 and #4646.

So I think we're back to the beginning where we need a new cloud provider proposal, with creation of a SIG and some evidence of active support for the new provider.

@ziggyw
Copy link
Author

ziggyw commented Apr 24, 2022

Hi @dbyron-sf I have submitted proposal: spinnaker/governance#292 , and these steps will be performed .

- Supports Cluster view
- Supports Instance、Instance Type、Image view
@ziggyw ziggyw requested a review from dbyron-sf April 24, 2022 06:03
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants