address review comments

Signed-off-by: karthik2804 <[email protected]>
spinframework · Jan 28, 2025 · 045f9b3 · 045f9b3
1 parent 2f223d2
commit 045f9b3
Show file tree

Hide file tree

Showing 19 changed files with 19 additions and 20 deletions.
diff --git a/examples/aws/s3/README.md b/examples/aws/s3/README.md
@@ -24,7 +24,7 @@ This example showcases how to connect to and send messages using Amazon S3 with
    const client = new S3Client({
        region: "us-west-2",
        credentials: {
-           accessKeyId: "<>>",
+           accessKeyId: "<>",
            secretAccessKey: "<>",
            sessionToken: "<>"
        },

diff --git a/examples/aws/s3/webpack.config.js b/examples/aws/s3/webpack.config.js
@@ -32,4 +32,4 @@ module.exports = {
     optimization: {
         minimize: false
     },
-};
+};
diff --git a/examples/aws/sqs/webpack.config.js b/examples/aws/sqs/webpack.config.js
@@ -32,4 +32,4 @@ module.exports = {
     optimization: {
         minimize: false
     },
-};
+};
diff --git a/examples/blob-storage/backblaze/webpack.config.js b/examples/blob-storage/backblaze/webpack.config.js
@@ -32,4 +32,4 @@ module.exports = {
     optimization: {
         minimize: false
     },
-};
+};
diff --git a/examples/common-patterns/outbound-http/webpack.config.js b/examples/common-patterns/outbound-http/webpack.config.js
@@ -32,4 +32,4 @@ module.exports = {
     optimization: {
         minimize: false
     },
-};
+};
diff --git a/examples/common-patterns/routing-requests/spin.toml b/examples/common-patterns/routing-requests/spin.toml
@@ -15,4 +15,4 @@ source = "dist/routing-requests.wasm"
 exclude_files = ["**/node_modules"]
 [component.routing-requests.build]
 command = ["npm install", "npm run build"]
-watch = ["src/**/*.ts"]
+watch = ["src/**/*.ts"]
diff --git a/examples/common-patterns/routing-requests/webpack.config.js b/examples/common-patterns/routing-requests/webpack.config.js
@@ -32,4 +32,4 @@ module.exports = {
     optimization: {
         minimize: false
     },
-};
+};
diff --git a/examples/github/octokit-rest/webpack.config.js b/examples/github/octokit-rest/webpack.config.js
@@ -32,4 +32,4 @@ module.exports = {
     optimization: {
         minimize: false
     },
-};
+};
diff --git a/examples/orm/drizzle/webpack.config.js b/examples/orm/drizzle/webpack.config.js
@@ -32,4 +32,4 @@ module.exports = {
     optimization: {
         minimize: false
     },
-};
+};
diff --git a/examples/serverless_db/neondb/webpack.config.js b/examples/serverless_db/neondb/webpack.config.js
@@ -32,4 +32,4 @@ module.exports = {
     optimization: {
         minimize: false
     },
-};
+};
diff --git a/examples/serverless_db/planetscale/webpack.config.js b/examples/serverless_db/planetscale/webpack.config.js
@@ -32,4 +32,4 @@ module.exports = {
     optimization: {
         minimize: false
     },
-};
+};
diff --git a/examples/spin-host-apis/spin-kv/src/index.ts b/examples/spin-host-apis/spin-kv/src/index.ts
@@ -13,7 +13,7 @@ router
     .get("*", async (req: Request) => {
         let store = Kv.openDefault();
         let status = 200;
-        let body;
+        let body = "Not Found";
 
         switch (req.method) {
             case 'POST':

diff --git a/examples/spin-host-apis/spin-kv/webpack.config.js b/examples/spin-host-apis/spin-kv/webpack.config.js
@@ -32,4 +32,4 @@ module.exports = {
     optimization: {
         minimize: false
     },
-};
+};
diff --git a/examples/spin-host-apis/spin-llm/webpack.config.js b/examples/spin-host-apis/spin-llm/webpack.config.js
@@ -32,4 +32,4 @@ module.exports = {
     optimization: {
         minimize: false
     },
-};
+};
diff --git a/examples/spin-host-apis/spin-mqtt/webpack.config.js b/examples/spin-host-apis/spin-mqtt/webpack.config.js
@@ -32,4 +32,4 @@ module.exports = {
     optimization: {
         minimize: false
     },
-};
+};
diff --git a/examples/upstash/qstash/src/index.ts b/examples/upstash/qstash/src/index.ts
@@ -16,7 +16,7 @@ router
             delay: 2,
         });
 
-        return new Response(JSON.stringify(resp), { status: 200 });
+        return new Response(JSON.stringify(resp, null, 2), { status: 200, headers: { "Content-Type": "application/json" } });
     })
 
 //@ts-ignore

diff --git a/examples/upstash/vector/src/index.ts b/examples/upstash/vector/src/index.ts
@@ -31,7 +31,7 @@ router
                 topK: 3,
                 includeMetadata: true,
             });
-            return new Response(JSON.stringify(data, null, 2), { status: 200 });
+            return new Response(JSON.stringify(data, null, 2), { status: 200, headers: { "Content-Type": "application/json" } });
         } catch (e: any) {
             return new Response(`error: ${e}`, { status: 500 });
         }

diff --git a/templates/http-js/content/src/index.js b/templates/http-js/content/src/index.js
@@ -1,4 +1,4 @@
-// https://itty.dev/itty-router/routers/autorouter
+// For AutoRouter documentation refer to https://itty.dev/itty-router/routers/autorouter
 import { AutoRouter } from 'itty-router';
 
 let router = AutoRouter();
@@ -10,7 +10,6 @@ router
     .get("/", () => new Response("hello universe"))
     .get('/hello/:name', ({ name }) => `Hello, ${name}!`)
 
-//@ts-ignore
 addEventListener('fetch', async (event) => {
     event.respondWith(router.fetch(event.request));
 });
diff --git a/templates/http-ts/content/src/index.ts b/templates/http-ts/content/src/index.ts
@@ -1,4 +1,4 @@
-// https://itty.dev/itty-router/routers/autorouter
+// For AutoRouter documentation refer to https://itty.dev/itty-router/routers/autorouter
 import { AutoRouter } from 'itty-router';
 
 let router = AutoRouter();
-Original file line number
+Diff line change
@@ Expand Up / @@ -32,4 +32,4 @@ module.exports = { @@
         optimization: {
             minimize: false
         },
-    };
+    };