Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Julia sysimage creation #152

Merged
merged 2 commits into from
Aug 22, 2023
Merged

Fix Julia sysimage creation #152

merged 2 commits into from
Aug 22, 2023

Conversation

soininen
Copy link
Contributor

@soininen soininen commented Aug 11, 2023

This PR resurrects Julia sysimage creation.

Accompanying PRs:
spine-tools/spine-engine#111
spine-tools/Spine-Toolbox#2246

Fixes spine-tools/Spine-Toolbox#1225

Checklist before merging

  • Documentation (also in Toolbox repo) is up-to-date
  • Release notes in Toolbox repo have been updated
  • Unit tests have been added/updated accordingly
  • Code has been formatted by black
  • Unit tests pass

Creating new Julia sysimages was temporarily disabled because it wasn't
working. This restores the functionality.

- Remove the early return from _create_sysimage() to enable the creation.
- Fix missing job id when creating Spine Engine Worker. There's a corresponding
  Toolbox side fix as well
- Fix Windows paths embedded in Julia code: we must escape '\' in Julia's
  strings.
- Don't supply Julia with the --project keyword if we don't have a project
  (the project is actually @.). There's a corresponding Engine side fix as
  well.
- Code beautification.

Re spine-tools/Spine-Toolbox#1225
@soininen
Copy link
Contributor Author

@manuelma I think I got the sysimage stuff working but I would appreciate it a lot if you could review the changes and perhaps test if everything is working as expected. Especially, the Julia code in options_widgets.py should be checked - I am unsure if there is nowadays better ways available in PackageCompiler to create the sysimage.

@codecov-commenter
Copy link

codecov-commenter commented Aug 14, 2023

Codecov Report

Patch coverage: 27.27% and no project coverage change.

Comparison is base (08f822b) 55.10% compared to head (dfe175e) 55.11%.
Report is 2 commits behind head on master.

❗ Current head dfe175e differs from pull request most recent head 5a13afd. Consider uploading reports for the commit 5a13afd to get more accurate results

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #152   +/-   ##
=======================================
  Coverage   55.10%   55.11%           
=======================================
  Files         192      192           
  Lines       17371    17376    +5     
  Branches     2849     2850    +1     
=======================================
+ Hits         9572     9576    +4     
- Misses       7304     7305    +1     
  Partials      495      495           
Files Changed Coverage Δ
spine_items/tool/widgets/options_widgets.py 25.51% <16.66%> (+0.41%) ⬆️
spine_items/tool/tool_instance.py 44.01% <25.00%> (-0.16%) ⬇️
spine_items/utils.py 64.64% <100.00%> (+0.72%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jkiviluo jkiviluo requested a review from manuelma August 18, 2023 13:45
@manuelma
Copy link
Collaborator

@manuelma I think I got the sysimage stuff working but I would appreciate it a lot if you could review the changes and perhaps test if everything is working as expected. Especially, the Julia code in options_widgets.py should be checked - I am unsure if there is nowadays better ways available in PackageCompiler to create the sysimage.

Looks good @soininen - I inspected the code and made a couple of comments - only one of them is a suggestion for a change. Maybe with more time I can test it and see how it works in reality, but my feeling is it should be close enough.

@soininen
Copy link
Contributor Author

@manuelma Thanks a lot for the review! I think we're good to go with this PR.

@soininen soininen merged commit b64f46d into master Aug 22, 2023
@soininen soininen deleted the 1225_julia_sysimages branch August 22, 2023 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for creating sysimages for Julia tools
3 participants