Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parameter types now need to be specified more accurately when unparsing #128

Merged
merged 1 commit into from
Aug 9, 2024

Conversation

Tasqu
Copy link
Member

@Tasqu Tasqu commented Aug 9, 2024

Real, String, Symbol, and Bool parameter value types now need to be specified when unparsing.

Fixes a bug where the above parameter types wouldn't be exported correctly into Datastores due to their unparsing lacking the type information required by Spine Database API.

Checklist before merging

  • Documentation is up-to-date
  • Release notes have been updated (we don't have any)
  • Unit tests have been added/updated accordingly
  • Code has been formatted nicely
  • Unit tests pass

@Tasqu Tasqu self-assigned this Aug 9, 2024
@Tasqu Tasqu merged commit 8bb6b91 into master Aug 9, 2024
5 checks passed
@Tasqu Tasqu deleted the fix_parameter_types_for_export branch August 9, 2024 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant