-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add cauda equina label to make lumbar registration more user-friendly #26
Comments
Thank you for these excellent questions @joshuacwnewton
I think this is fine.
I think this is also fine. Probably better in fact, because as you pointed out the new cord seg should now be available in PAM50 (or will be at the time of the course)
I would not do that, as it might create confusing with the existing label, users will forget to put it back afterwards, etc. I can see a lot of issues that would be hard for us to debug remotely
Yeah I agree. How about we go with
I'd rather keep the 1-->70ish for us. Putting custom values "in between" might create confusion. |
I'm very okay with this. :)
Just to clarify, though, what do you mean by "for us"? In other words, I'm curious how the cauda equinea label is any different from, e.g. the PMJ label ( |
Ah wait, my apologies. In that case, using label |
i meant values of labels included in the PAM50 or future templates (eg the work of Nilser) |
@joshuacwnewton I'm very sorry but I misunderstood what was the intention of this issue and related PR-- I thought the plan was only to create a tutorial where we show how to make custom labels (hence the suggestion of Your solution (ie: modify our |
Exactly. (My plan was to address both spinalcordtoolbox/spinalcordtoolbox#4180 and spinalcordtoolbox/spinalcordtoolbox#3599 in one go.) My apologies if my intention was unclear. 😅
Exactly my thinking! I'll update the PR to use this value instead. |
…ier lumbar registration (#27) As per #26 (comment).
As part of spinalcordtoolbox/spinalcordtoolbox#3599 and spinalcordtoolbox/spinalcordtoolbox#4180, we have two good forum posts demonstrating how to perform lumbar registration with a new custom label.
In both cases, we asked the users to manually label a location on the PAM50 template representing the cauda equinea:
[70,69,46]
.[70,70,40]
.Some questions:
[70,69,46]
.[70,70,40]
.[70,70,39]
.99
is used for the cauda equinea label. However, this label is (kind of) reserved for the dummy label used insct_register_to_template
, plus this value doesn't really fit with the existing label conventions (1-25, 49, 50).30
or40
? (This would follow the example given by the PMJ-related labels 50/49, while also giving plenty of room above and below for future labels, since the L5-S1 disc uses label25
.)The text was updated successfully, but these errors were encountered: