Upgrade to go1.14.6 #1741
Merged
Upgrade to go1.14.6 #1741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrew Harding <[email protected]>
azdagron
requested review from
amartinezfayo,
APTy,
evan2645 and
mcpherrinm
as code owners
mcpherrinm
approved these changes
Jul 23, 2020
amartinezfayo
approved these changes
Jul 23, 2020
| @@ -2795,7 +2795,7 @@ func (s *PluginSuite) TestConfigure() { | |||
| giveDBConfig: ` | |||
| max_open_conns = 1000 | |||
| max_idle_conns = 50 | |||
| conn_max_lifetime = "1ms" | |||
| conn_max_lifetime = "10s" | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrades to Go 1.14.6 which contains a fix for transaction handling in the
sqlpackage when a transaction is rolled back due to context cancellation (golang/go#39101)Also bumps up the "max connection lifetime" value in a unit test that was accidentally causing all of the idle connections to be closed before they could be inspected. Presumably the changes in go1.14.6 caused the connection lifetime to be checked more aggressively or changed the timing.