Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: Add hint field to X509Certificate and JWTKey in bundle #45

Open
wants to merge 1 commit into
base: next
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
74 changes: 49 additions & 25 deletions proto/spire/api/types/bundle.pb.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 10 additions & 0 deletions proto/spire/api/types/bundle.proto
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,11 @@ message X509Certificate {

// This authority is no longer secure and must not be used.
bool tainted = 2;

// Optional. A hint on where the certificate came from. This is not intended to be
// parsed by SPIRE, but rather to be used by the API consumer to determine
// how to interpret the certificate.
string hint = 3;
}

message JWTKey {
Expand All @@ -41,6 +46,11 @@ message JWTKey {

// This authority is no longer secure and must not be used
bool tainted = 4;

// Optional. A hint on where the certificate came from. This is not intended to be
// parsed by SPIRE, but rather to be used by the API consumer to determine
// how to interpret the jwt key.
string hint = 5;
}

message BundleMask {
Expand Down