Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for SPIFFE_ENDPOINT_SOCKET, deprecate SPIRE_AGENT_ADDRESS #214

Merged
merged 3 commits into from
Nov 21, 2024
Merged

Add support for SPIFFE_ENDPOINT_SOCKET, deprecate SPIRE_AGENT_ADDRESS #214

merged 3 commits into from
Nov 21, 2024

Conversation

faisal-memon
Copy link
Collaborator

fixes #90

@faisal-memon faisal-memon added this to the 0.9.0 milestone Nov 12, 2024
kfox1111
kfox1111 approved these changes Nov 14, 2024
View reviewed changes
Copy link
Contributor

@kfox1111 kfox1111 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks! :)

@faisal-memon faisal-memon merged commit 71c0897 into main Nov 21, 2024
13 checks passed
@faisal-memon faisal-memon deleted the spiffe_endpoint_address branch November 21, 2024 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarcosDY MarcosDY MarcosDY approved these changes

@kfox1111 kfox1111 kfox1111 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.9.0
Development

Successfully merging this pull request may close these issues.

Change SPIRE_AGENT_ADDRESS to SPIFFE_ENDPOINT_SOCKET
3 participants
@faisal-memon @kfox1111 @MarcosDY