Skip to content

Commit

Permalink
Remove redundant Dockerfile in tests
Browse files Browse the repository at this point in the history
  • Loading branch information
faisal-memon committed Nov 11, 2024
1 parent cc6d800 commit a1094b2
Show file tree
Hide file tree
Showing 4 changed files with 11 additions and 7 deletions.
3 changes: 2 additions & 1 deletion .github/tests/it/build.sh
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,8 @@ docker compose exec spire-server ./bin/spire-server entry create \
# set ups spire agent
docker compose up spire-agent -d

docker compose build spiffe-helper
go_version=$(sed -En 's/^go[ ]+([0-9.]+).*/\1/p' ../../../go.mod)
docker compose build --build-arg go_version=$go_version spiffe-helper

# set ups and postgres-db
docker compose up postgres-db -d
Expand Down
4 changes: 3 additions & 1 deletion .github/tests/it/docker-compose.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,9 @@ services:
spiffe-helper:
build:
context: ../../../
dockerfile: ./.github/tests/it/spiffe-helper/Dockerfile
dockerfile: ./Dockerfile
args:
- go_version

postgres-db:
build: postgres
Expand Down
4 changes: 0 additions & 4 deletions .github/tests/it/spiffe-helper/Dockerfile

This file was deleted.

7 changes: 6 additions & 1 deletion .github/workflows/pr_build.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,12 @@ jobs:
matrix:
tests: ${{ fromJson(needs.build-matrix.outputs.tests) }}
steps:
- uses: actions/checkout@v4
- name: Checkout
uses: actions/checkout@v4
- name: Setup go
uses: actions/setup-go@v5
with:
go-version-file: 'go.mod'
- name: Build containers
run: ./build.sh
shell: bash
Expand Down

0 comments on commit a1094b2

Please sign in to comment.