Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add extraEnvVars support for spiffe-csi-driver containers #496

Merged
merged 1 commit into from
Nov 17, 2024
Merged

Add extraEnvVars support for spiffe-csi-driver containers #496

merged 1 commit into from
Nov 17, 2024

Conversation

poblahblahblah
Copy link
Contributor

We are wanting to pass GOMAXPROCS and GOMEMLIMIT to the spiffe-csi-driver containers. This adds support for it.

@poblahblahblah poblahblahblah force-pushed the add-extraEnvVars-to-spiffe-csi-driver branch from 465237b to 1b8853f Compare November 15, 2024 19:55
@poblahblahblah
Add extraEnvVars support for spiffe-csi-driver containers
1b6829f 
Signed-off-by: Patrick O'Brien <[email protected]>
Signed-off-by: Patrick O’Brien <[email protected]>
@poblahblahblah poblahblahblah force-pushed the add-extraEnvVars-to-spiffe-csi-driver branch from 1b8853f to 1b6829f Compare November 15, 2024 19:56
kfox1111
kfox1111 approved these changes Nov 15, 2024
View reviewed changes
Copy link
Collaborator

@kfox1111 kfox1111 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks! :)

@faisal-memon faisal-memon merged commit 6608fc9 into spiffe:main Nov 17, 2024
37 checks passed
faisal-memon added a commit that referenced this pull request Nov 17, 2024
@faisal-memon
Bump spire Helm Chart version from 0.24.0 to 0.24.1
171f6af 
* 6608fc9 Add extraEnvVars support for spiffe-csi-driver containers (#496)
* 6193717 Bump test chart dependencies (#494)
* d5777c3 Bump test chart dependencies (#493)
* 4993b67 Fix GCS Bundle endpoint format variable (#491)

Signed-off-by: Faisal Memon <[email protected]>
This was referenced Nov 17, 2024
Merged
Merged
Merged
kfox1111 pushed a commit that referenced this pull request Nov 17, 2024
@faisal-memon
Bump spire Helm Chart version from 0.24.0 to 0.24.1 (#497)
61eb715 
* 6608fc9 Add extraEnvVars support for spiffe-csi-driver containers (#496)
* 6193717 Bump test chart dependencies (#494)
* d5777c3 Bump test chart dependencies (#493)
* 4993b67 Fix GCS Bundle endpoint format variable (#491)

Signed-off-by: Faisal Memon <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kfox1111 kfox1111 kfox1111 approved these changes

@marcofranssen marcofranssen Awaiting requested review from marcofranssen marcofranssen is a code owner

@faisal-memon faisal-memon Awaiting requested review from faisal-memon faisal-memon is a code owner

@mrsabath mrsabath Awaiting requested review from mrsabath mrsabath is a code owner

@edwbuck edwbuck Awaiting requested review from edwbuck edwbuck is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@poblahblahblah @kfox1111 @faisal-memon