Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: don't install themes if current_theme isn't marketplace #673

Merged
merged 1 commit into from
Dec 18, 2023
Merged

feat: don't install themes if current_theme isn't marketplace #673

merged 1 commit into from
Dec 18, 2023

Conversation

SunsetTechuila
Copy link
Contributor

No description provided.

@SunsetTechuila SunsetTechuila requested a review from a team as a code owner December 17, 2023 15:24
@SunsetTechuila SunsetTechuila requested review from rxri and removed request for a team December 17, 2023 15:24
@CharlieS1103
Copy link
Member

Is this something we really want?

@SunsetTechuila
Copy link
Contributor Author

SunsetTechuila commented Dec 17, 2023 •
edited
Loading

Since themes don't work correctly without setting current_theme to marketplace, I think it is

@SunsetTechuila
Copy link
Contributor Author

I've seen a lot of people having issues with themes from the marketplace because they didn't do that

@theRealPadster theRealPadster merged commit 700bb74 into spicetify:main Dec 18, 2023
5 checks passed
@SunsetTechuila SunsetTechuila deleted the themes branch December 18, 2023 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theRealPadster theRealPadster theRealPadster approved these changes

@rxri rxri Awaiting requested review from rxri rxri is a code owner automatically assigned from spicetify/marketplace

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SunsetTechuila @CharlieS1103 @theRealPadster