Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(windows install): refactor posh install script #528

Merged
merged 3 commits into from
Jun 25, 2023
Merged

refactor(windows install): refactor posh install script #528

merged 3 commits into from
Jun 25, 2023

Conversation

SunsetTechuila
Copy link
Contributor

based on Microsoft guidelines, community The PowerShell Best Practices and Style Guide and PSScriptAnalyzer warnings
also minor logic improvements

@SunsetTechuila SunsetTechuila requested a review from a team as a code owner June 25, 2023 13:20
@SunsetTechuila SunsetTechuila requested review from rxri and removed request for a team June 25, 2023 13:20
Copy link
Member

@kyrie25 kyrie25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just for consistency

resources/install.ps1 Outdated Show resolved Hide resolved
@kyrie25 kyrie25 merged commit 26303e0 into spicetify:main Jun 25, 2023
rxri added a commit that referenced this pull request Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants