Custom app - New Releases Infinite Loading #1539
Labels
Comments
|
Check it out on the new version, I think it should have been fixed now! Re-open if that is not the case π€ |
it has not been fixed in Spicetify: v2.9.4 |
afonsojramos
changed the title
|
I'd be willing to bet this is because the viewport selector is no longer valid |
|
I will test it later today |
|
Reddit wasn't infinite loading I only got errors with menu hooks, if they were fixed then probably the issue is just with New Releases now |
|
I have the same issue:
Unfortunately, enabling developer tools doesn't work. I can't open them. |
|
New Releases infinite loading issue is due to Since it was removed (or depreciated?), it can't fetch necessary data |
Do you think this can even be fixed after this change? |
It should, yes - there is already PR for I'm actually testing if this also works for |
th3an7
added a commit
to th3an7/spicetify-cli
that referenced
this issue
Mar 29, 2022
- Based on proposed fix for `Shuffle+` (spicetify#1559) - Fixes spicetify#1539 spicetify#1530 Notes: - Can probably be written nicer - this is my scuffed attempt to fix it - May or may not actually show all new releases for all followed artists - have over 665 of them but I don't think I'm getting all of them (see below) - May or may not return `error 500` (added `.catch()` block keeps it from breaking whole custom app)
|
I've managed to partly fix it by looking at that PR I've mentioned above... it works (kinda) but I'm pretty sure it doesn't show all releases for all artists... here is my edited code - not sending PR yet as it probably can be fixed by someone smarter than me... |
guttitto
changed the title
this actually fixed it for me! thanks for the fix! |
Hey, glad to hear that :D Could you also please test my latest changes made in th3an7@604b2dd? If you have big library of followed artists (655+ in my case), this should return more data before it errors out - you'll still miss some releases from couple artists, but not to that degree as in previous fix. This note is just to add notification in #1530 |
|
@th3an7 please feel free to open a PR if you end up fixing it π |
|
|
You can just replace file manually and then do |
|
I don't know if this is related or not but my spotify app doesn't load at all. I tried to clear the backups to get a vanilla install of spicetify (if that makes sense) but it always kept displaying the gray screen that is visible when starting. I can start music with media keys tho. |
i had this twice before and had to reinstall spotify and spicetify twice too. but it seems like the issue was with one of the extensions or snippets so i just installed less of them. hope this helps |
|
Will try that, thanks @Mcfly2340! |
Worked, thank you π |
afonsojramos
pushed a commit
that referenced
this issue
Apr 6, 2022
* Fix `New Releases` custom app for Spotify 1.1.81+ - Based on proposed fix for `Shuffle+` (#1559) - Fixes #1539 #1530 Notes: - Can probably be written nicer - this is my scuffed attempt to fix it - May or may not actually show all new releases for all followed artists - have over 665 of them but I don't think I'm getting all of them (see below) - May or may not return `error 500` (added `.catch()` block keeps it from breaking whole custom app) * Minimize `internal server error: 500`... ...for big libraries of followed artists. Changes: - Change `URL` to query only discographies - Limit amount of queried albums to 5 Notes: - This does **NOT** fixes erroring fully - it only maxes out amount of data you can query before getting rate limited - The more options you select (ex. albums + EPs + podcasts), the less data you may receive - To max number of albums received, I recommend to select only `Albums` (since `Singles and EPs` will probably get displayed anyway...) * Add notifications when error occurred Notifications added: - Error code (`500`, `429` etc.) - Amount of followed artists to fetch releases from - Amount of followed artists failed to fetch releases from I guess we have to get along with getting `500-ed` - one time it fetches everything instantly, second time it drops 60 artists... * "Prettify" file to pass `Prettier` test * Fix filtering, counter... - Fixing filtering as no matter was what set in config, it always displayed everything as "Album" - Fixing "Missing releases from..." counter - should properly reset now What broke again: - "Appears on" releases cannot be retrieved with that API endpoint - this filter is just there and doesn't do anything - this prevents from showing everything as "Appears on" etc. Notes: - There seem to be an API endpoint for retrieving "Related content" stuff - problem is that would query everything TWICE... which breaks everything even more (and we don't wanna do that) - If someone knows how to query everything using separate endpoint without doing it 4 times, let me know... * Forgor `( )`... Oops... π I forgor π * Include requested changes Changes: - Properly encode URI including variables - Make `limit` variable customizable via settings (set default to 5) - Make error messages as "dev console only" Notes: - Errors displayed in console may be a little spammy - if we get error early, there may be lots of lines displaying it + counter... * I'm not too sure how to tackle this - just remove them altogether? Or is there a function that could "suppress" them? * Switching from normal `log` to `debug` may help a little as they will be only visible if user has set their console log level to include `Verbose` - Making `limit` customizable may lead to even more errors but fuck it I guess - it's better to have a choice than not, right? * It can be manually input via custom app settings (same place where other options are) - there is no list etc. - it's just normal input field - Set `offset` value as const `0` and not making it customizable (cause why would you want to start searching from ex. 3rd album instead of beginning, right?) - Leaving `Fetching releases from...` notification cause it looks cool - it's fun to know how many followed artists you have π
rxri
pushed a commit
that referenced
this issue
Apr 14, 2022
* Fix `New Releases` custom app for Spotify 1.1.81+ - Based on proposed fix for `Shuffle+` (#1559) - Fixes #1539 #1530 Notes: - Can probably be written nicer - this is my scuffed attempt to fix it - May or may not actually show all new releases for all followed artists - have over 665 of them but I don't think I'm getting all of them (see below) - May or may not return `error 500` (added `.catch()` block keeps it from breaking whole custom app) * Minimize `internal server error: 500`... ...for big libraries of followed artists. Changes: - Change `URL` to query only discographies - Limit amount of queried albums to 5 Notes: - This does **NOT** fixes erroring fully - it only maxes out amount of data you can query before getting rate limited - The more options you select (ex. albums + EPs + podcasts), the less data you may receive - To max number of albums received, I recommend to select only `Albums` (since `Singles and EPs` will probably get displayed anyway...) * Add notifications when error occurred Notifications added: - Error code (`500`, `429` etc.) - Amount of followed artists to fetch releases from - Amount of followed artists failed to fetch releases from I guess we have to get along with getting `500-ed` - one time it fetches everything instantly, second time it drops 60 artists... * "Prettify" file to pass `Prettier` test * Fix filtering, counter... - Fixing filtering as no matter was what set in config, it always displayed everything as "Album" - Fixing "Missing releases from..." counter - should properly reset now What broke again: - "Appears on" releases cannot be retrieved with that API endpoint - this filter is just there and doesn't do anything - this prevents from showing everything as "Appears on" etc. Notes: - There seem to be an API endpoint for retrieving "Related content" stuff - problem is that would query everything TWICE... which breaks everything even more (and we don't wanna do that) - If someone knows how to query everything using separate endpoint without doing it 4 times, let me know... * Forgor `( )`... Oops... π I forgor π * Include requested changes Changes: - Properly encode URI including variables - Make `limit` variable customizable via settings (set default to 5) - Make error messages as "dev console only" Notes: - Errors displayed in console may be a little spammy - if we get error early, there may be lots of lines displaying it + counter... * I'm not too sure how to tackle this - just remove them altogether? Or is there a function that could "suppress" them? * Switching from normal `log` to `debug` may help a little as they will be only visible if user has set their console log level to include `Verbose` - Making `limit` customizable may lead to even more errors but fuck it I guess - it's better to have a choice than not, right? * It can be manually input via custom app settings (same place where other options are) - there is no list etc. - it's just normal input field - Set `offset` value as const `0` and not making it customizable (cause why would you want to start searching from ex. 3rd album instead of beginning, right?) - Leaving `Fetching releases from...` notification cause it looks cool - it's fun to know how many followed artists you have π
afonsojramos
added a commit
that referenced
this issue
Apr 14, 2022
* fix: patch prefs on windows * fix: fix type mismatch * fix: `New Releases` custom app for Spotify 1.1.81+ (#1563) * Fix `New Releases` custom app for Spotify 1.1.81+ - Based on proposed fix for `Shuffle+` (#1559) - Fixes #1539 #1530 Notes: - Can probably be written nicer - this is my scuffed attempt to fix it - May or may not actually show all new releases for all followed artists - have over 665 of them but I don't think I'm getting all of them (see below) - May or may not return `error 500` (added `.catch()` block keeps it from breaking whole custom app) * Minimize `internal server error: 500`... ...for big libraries of followed artists. Changes: - Change `URL` to query only discographies - Limit amount of queried albums to 5 Notes: - This does **NOT** fixes erroring fully - it only maxes out amount of data you can query before getting rate limited - The more options you select (ex. albums + EPs + podcasts), the less data you may receive - To max number of albums received, I recommend to select only `Albums` (since `Singles and EPs` will probably get displayed anyway...) * Add notifications when error occurred Notifications added: - Error code (`500`, `429` etc.) - Amount of followed artists to fetch releases from - Amount of followed artists failed to fetch releases from I guess we have to get along with getting `500-ed` - one time it fetches everything instantly, second time it drops 60 artists... * "Prettify" file to pass `Prettier` test * Fix filtering, counter... - Fixing filtering as no matter was what set in config, it always displayed everything as "Album" - Fixing "Missing releases from..." counter - should properly reset now What broke again: - "Appears on" releases cannot be retrieved with that API endpoint - this filter is just there and doesn't do anything - this prevents from showing everything as "Appears on" etc. Notes: - There seem to be an API endpoint for retrieving "Related content" stuff - problem is that would query everything TWICE... which breaks everything even more (and we don't wanna do that) - If someone knows how to query everything using separate endpoint without doing it 4 times, let me know... * Forgor `( )`... Oops... π I forgor π * Include requested changes Changes: - Properly encode URI including variables - Make `limit` variable customizable via settings (set default to 5) - Make error messages as "dev console only" Notes: - Errors displayed in console may be a little spammy - if we get error early, there may be lots of lines displaying it + counter... * I'm not too sure how to tackle this - just remove them altogether? Or is there a function that could "suppress" them? * Switching from normal `log` to `debug` may help a little as they will be only visible if user has set their console log level to include `Verbose` - Making `limit` customizable may lead to even more errors but fuck it I guess - it's better to have a choice than not, right? * It can be manually input via custom app settings (same place where other options are) - there is no list etc. - it's just normal input field - Set `offset` value as const `0` and not making it customizable (cause why would you want to start searching from ex. 3rd album instead of beginning, right?) - Leaving `Fetching releases from...` notification cause it looks cool - it's fun to know how many followed artists you have π * add: go formatting to the pipeline (#1574) * add: go formatting to the pipeline * formatted missing files * chore: add print for files with bad formatting * style(utils/config): make file prettier Signed-off-by: ririxidev <[email protected]> * run go fmt Co-authored-by: Εukasz Ordon <[email protected]> Co-authored-by: Afonso Jorge Ramos <[email protected]> Co-authored-by: ririxidev <[email protected]>
CharlieS1103
added a commit
that referenced
this issue
May 13, 2022
* feat: add path for void linux (#1534) * fix: patch part of menu hook (#1529) Co-authored-by: Afonso Jorge Ramos <[email protected]> * fix: `fullAppDisplay` album info & background (#1543) * temporary solution for #1538 As the hermes protocol is broken `1.1.81` onwards, this can "fix" the issue. Now the lyrics-plus background will always match spotify lyrics background. Maybe, in the future, there is a way to restore the old colorextractor. * updated `fullAppDisplay` to source album info 1.1.81 onwards Again, hermes protocol gone, fixed album info * removed obsolete code from `fullAppDisplay` and `lyrics-plus` Co-authored-by: Afonso Jorge Ramos <[email protected]> * upgrade: Go 1.18 (#1547) Signed-off-by: Moulick Aggarwal <[email protected]> * fix: menu hook and menu item hook patches (#1548) * Patch part of Menu hook * Patch Menu Item hook! ISSUE RESOLVED * chore(shuffle+): updated api (#1559) `hm://` protocol deprecated, used alternatives to fetch album's and artist's data. * fix(fullAppDisplay): background for full screen display on a vertical monitor (#1560) * Fix background for full screen display on a vertical monitor * Fix code formatting Co-authored-by: Afonso Jorge Ramos <[email protected]> * chore: restructure install.sh (#1535) * change script * add adding to shell profile * add arm64 * remove arm64 and add aarch64 Co-authored-by: Afonso Jorge Ramos <[email protected]> * fix: `New Releases` custom app for Spotify 1.1.81+ (#1563) * Fix `New Releases` custom app for Spotify 1.1.81+ - Based on proposed fix for `Shuffle+` (#1559) - Fixes #1539 #1530 Notes: - Can probably be written nicer - this is my scuffed attempt to fix it - May or may not actually show all new releases for all followed artists - have over 665 of them but I don't think I'm getting all of them (see below) - May or may not return `error 500` (added `.catch()` block keeps it from breaking whole custom app) * Minimize `internal server error: 500`... ...for big libraries of followed artists. Changes: - Change `URL` to query only discographies - Limit amount of queried albums to 5 Notes: - This does **NOT** fixes erroring fully - it only maxes out amount of data you can query before getting rate limited - The more options you select (ex. albums + EPs + podcasts), the less data you may receive - To max number of albums received, I recommend to select only `Albums` (since `Singles and EPs` will probably get displayed anyway...) * Add notifications when error occurred Notifications added: - Error code (`500`, `429` etc.) - Amount of followed artists to fetch releases from - Amount of followed artists failed to fetch releases from I guess we have to get along with getting `500-ed` - one time it fetches everything instantly, second time it drops 60 artists... * "Prettify" file to pass `Prettier` test * Fix filtering, counter... - Fixing filtering as no matter was what set in config, it always displayed everything as "Album" - Fixing "Missing releases from..." counter - should properly reset now What broke again: - "Appears on" releases cannot be retrieved with that API endpoint - this filter is just there and doesn't do anything - this prevents from showing everything as "Appears on" etc. Notes: - There seem to be an API endpoint for retrieving "Related content" stuff - problem is that would query everything TWICE... which breaks everything even more (and we don't wanna do that) - If someone knows how to query everything using separate endpoint without doing it 4 times, let me know... * Forgor `( )`... Oops... π I forgor π * Include requested changes Changes: - Properly encode URI including variables - Make `limit` variable customizable via settings (set default to 5) - Make error messages as "dev console only" Notes: - Errors displayed in console may be a little spammy - if we get error early, there may be lots of lines displaying it + counter... * I'm not too sure how to tackle this - just remove them altogether? Or is there a function that could "suppress" them? * Switching from normal `log` to `debug` may help a little as they will be only visible if user has set their console log level to include `Verbose` - Making `limit` customizable may lead to even more errors but fuck it I guess - it's better to have a choice than not, right? * It can be manually input via custom app settings (same place where other options are) - there is no list etc. - it's just normal input field - Set `offset` value as const `0` and not making it customizable (cause why would you want to start searching from ex. 3rd album instead of beginning, right?) - Leaving `Fetching releases from...` notification cause it looks cool - it's fun to know how many followed artists you have π * add: go formatting to the pipeline (#1574) * add: go formatting to the pipeline * formatted missing files * chore: add print for files with bad formatting * fix: specific version fetching in install script (#1578) * chore: enhance specific version fetch (#1582) * fix: specific version fetching in install script * fix: Remove unnecessary request when specifying a version * fix: Allow for input without "v" * No special print for the latest version Instead of printing "Latest version", it prints "Version x.y.z" * chore: better naming of "shortcut" Co-authored-by: FlafyDev <[email protected]> * chore: added community funding option * fix: readme links (#1584) * chore: add bash_profile fallback for bash (#1583) * chore: add bash_profile fallback for bash * applied suggested changes Co-authored-by: wael444 <[email protected]> * revert part of the suggested changes Co-authored-by: wael444 <[email protected]> * fix(windows): add missing prefs message (#1571) * fix: patch prefs on windows * fix: fix type mismatch * fix: `New Releases` custom app for Spotify 1.1.81+ (#1563) * Fix `New Releases` custom app for Spotify 1.1.81+ - Based on proposed fix for `Shuffle+` (#1559) - Fixes #1539 #1530 Notes: - Can probably be written nicer - this is my scuffed attempt to fix it - May or may not actually show all new releases for all followed artists - have over 665 of them but I don't think I'm getting all of them (see below) - May or may not return `error 500` (added `.catch()` block keeps it from breaking whole custom app) * Minimize `internal server error: 500`... ...for big libraries of followed artists. Changes: - Change `URL` to query only discographies - Limit amount of queried albums to 5 Notes: - This does **NOT** fixes erroring fully - it only maxes out amount of data you can query before getting rate limited - The more options you select (ex. albums + EPs + podcasts), the less data you may receive - To max number of albums received, I recommend to select only `Albums` (since `Singles and EPs` will probably get displayed anyway...) * Add notifications when error occurred Notifications added: - Error code (`500`, `429` etc.) - Amount of followed artists to fetch releases from - Amount of followed artists failed to fetch releases from I guess we have to get along with getting `500-ed` - one time it fetches everything instantly, second time it drops 60 artists... * "Prettify" file to pass `Prettier` test * Fix filtering, counter... - Fixing filtering as no matter was what set in config, it always displayed everything as "Album" - Fixing "Missing releases from..." counter - should properly reset now What broke again: - "Appears on" releases cannot be retrieved with that API endpoint - this filter is just there and doesn't do anything - this prevents from showing everything as "Appears on" etc. Notes: - There seem to be an API endpoint for retrieving "Related content" stuff - problem is that would query everything TWICE... which breaks everything even more (and we don't wanna do that) - If someone knows how to query everything using separate endpoint without doing it 4 times, let me know... * Forgor `( )`... Oops... π I forgor π * Include requested changes Changes: - Properly encode URI including variables - Make `limit` variable customizable via settings (set default to 5) - Make error messages as "dev console only" Notes: - Errors displayed in console may be a little spammy - if we get error early, there may be lots of lines displaying it + counter... * I'm not too sure how to tackle this - just remove them altogether? Or is there a function that could "suppress" them? * Switching from normal `log` to `debug` may help a little as they will be only visible if user has set their console log level to include `Verbose` - Making `limit` customizable may lead to even more errors but fuck it I guess - it's better to have a choice than not, right? * It can be manually input via custom app settings (same place where other options are) - there is no list etc. - it's just normal input field - Set `offset` value as const `0` and not making it customizable (cause why would you want to start searching from ex. 3rd album instead of beginning, right?) - Leaving `Fetching releases from...` notification cause it looks cool - it's fun to know how many followed artists you have π * add: go formatting to the pipeline (#1574) * add: go formatting to the pipeline * formatted missing files * chore: add print for files with bad formatting * style(utils/config): make file prettier Signed-off-by: ririxidev <[email protected]> * run go fmt Co-authored-by: Εukasz Ordon <[email protected]> Co-authored-by: Afonso Jorge Ramos <[email protected]> Co-authored-by: ririxidev <[email protected]> * fix(new-releases): switch to `wg://` protocol (#1590) * fix(lyrics): switch to `wg://` protocol (#1587) * fix: change protocol to wg:// * Fixes issues with getting spotify lyrics on lyrics-plus & popupLyrics * Add @ts-nocheck on popupLyrics Fixes #1566 * style: change wording when no lyrics * Update Extensions/popupLyrics.js Co-authored-by: Afonso Jorge Ramos <[email protected]> * fixed prettier error Co-authored-by: Afonso Jorge Ramos <[email protected]> * fix: Fix hooks for Spotify 1.1.83 (#1600) * Fix (New-Releases) : Cards Being Displayed Incorrectly (#1606) Due to the CSS Change In 1.1.83+, song cards were being displayed incorrectly. * fix(devtools): use new method to enable devtools (#1613) * Update css-map.json with latest main-trackInfo-* (#1610) * fix(devtools): overwrite homePath if snap detected (#1614) * fix: modify filePath from .config to .cache (#1618) Co-authored-by: ririxi <[email protected]> * fix(keyboardShortcut): update selector (#1617) * fix queue shortcut * change to double quote * feat(restart): check if process is running (#1623) * fix: Lyrics Plus not showing full lyrics (#1627) * fix(lyrics-plus): add null check (#1630) * fix(lyrics-plus): switch to `wg://` protocol for colors (#1631) * fix(wrapper): adapt few functions to `wg://` protocol (#1632) * fix: adapt urls in custom app & extensions to `wg://` protocol (#1633) * chore(lyrics-plus): use DOMParser to parse the genius (#1636) * fix(devtools): patch another location (#1647) * fix(sidebar-config): get elements by classname (#1654) Co-authored-by: wael444 <[email protected]> Co-authored-by: Afonso Jorge Ramos <[email protected]> Co-authored-by: huhridge <[email protected]> Co-authored-by: Moulick Aggarwal <[email protected]> Co-authored-by: kwerdenker <[email protected]> Co-authored-by: Εukasz Ordon <[email protected]> Co-authored-by: FlafyDev <[email protected]> Co-authored-by: The Blob SCP <[email protected]> Co-authored-by: ririxidev <[email protected]> Co-authored-by: itsmeow <[email protected]> Co-authored-by: ExHigh <[email protected]> Co-authored-by: Julien <[email protected]> Co-authored-by: Kafva <[email protected]> Co-authored-by: ajiou <[email protected]> Co-authored-by: Nam Anh <[email protected]> Co-authored-by: Jeroen <[email protected]>
CharlieS1103
added a commit
that referenced
this issue
May 13, 2022
* feat: add path for void linux (#1534) * fix: patch part of menu hook (#1529) Co-authored-by: Afonso Jorge Ramos <[email protected]> * fix: `fullAppDisplay` album info & background (#1543) * temporary solution for #1538 As the hermes protocol is broken `1.1.81` onwards, this can "fix" the issue. Now the lyrics-plus background will always match spotify lyrics background. Maybe, in the future, there is a way to restore the old colorextractor. * updated `fullAppDisplay` to source album info 1.1.81 onwards Again, hermes protocol gone, fixed album info * removed obsolete code from `fullAppDisplay` and `lyrics-plus` Co-authored-by: Afonso Jorge Ramos <[email protected]> * upgrade: Go 1.18 (#1547) Signed-off-by: Moulick Aggarwal <[email protected]> * fix: menu hook and menu item hook patches (#1548) * Patch part of Menu hook * Patch Menu Item hook! ISSUE RESOLVED * chore(shuffle+): updated api (#1559) `hm://` protocol deprecated, used alternatives to fetch album's and artist's data. * fix(fullAppDisplay): background for full screen display on a vertical monitor (#1560) * Fix background for full screen display on a vertical monitor * Fix code formatting Co-authored-by: Afonso Jorge Ramos <[email protected]> * chore: restructure install.sh (#1535) * change script * add adding to shell profile * add arm64 * remove arm64 and add aarch64 Co-authored-by: Afonso Jorge Ramos <[email protected]> * fix: `New Releases` custom app for Spotify 1.1.81+ (#1563) * Fix `New Releases` custom app for Spotify 1.1.81+ - Based on proposed fix for `Shuffle+` (#1559) - Fixes #1539 #1530 Notes: - Can probably be written nicer - this is my scuffed attempt to fix it - May or may not actually show all new releases for all followed artists - have over 665 of them but I don't think I'm getting all of them (see below) - May or may not return `error 500` (added `.catch()` block keeps it from breaking whole custom app) * Minimize `internal server error: 500`... ...for big libraries of followed artists. Changes: - Change `URL` to query only discographies - Limit amount of queried albums to 5 Notes: - This does **NOT** fixes erroring fully - it only maxes out amount of data you can query before getting rate limited - The more options you select (ex. albums + EPs + podcasts), the less data you may receive - To max number of albums received, I recommend to select only `Albums` (since `Singles and EPs` will probably get displayed anyway...) * Add notifications when error occurred Notifications added: - Error code (`500`, `429` etc.) - Amount of followed artists to fetch releases from - Amount of followed artists failed to fetch releases from I guess we have to get along with getting `500-ed` - one time it fetches everything instantly, second time it drops 60 artists... * "Prettify" file to pass `Prettier` test * Fix filtering, counter... - Fixing filtering as no matter was what set in config, it always displayed everything as "Album" - Fixing "Missing releases from..." counter - should properly reset now What broke again: - "Appears on" releases cannot be retrieved with that API endpoint - this filter is just there and doesn't do anything - this prevents from showing everything as "Appears on" etc. Notes: - There seem to be an API endpoint for retrieving "Related content" stuff - problem is that would query everything TWICE... which breaks everything even more (and we don't wanna do that) - If someone knows how to query everything using separate endpoint without doing it 4 times, let me know... * Forgor `( )`... Oops... π I forgor π * Include requested changes Changes: - Properly encode URI including variables - Make `limit` variable customizable via settings (set default to 5) - Make error messages as "dev console only" Notes: - Errors displayed in console may be a little spammy - if we get error early, there may be lots of lines displaying it + counter... * I'm not too sure how to tackle this - just remove them altogether? Or is there a function that could "suppress" them? * Switching from normal `log` to `debug` may help a little as they will be only visible if user has set their console log level to include `Verbose` - Making `limit` customizable may lead to even more errors but fuck it I guess - it's better to have a choice than not, right? * It can be manually input via custom app settings (same place where other options are) - there is no list etc. - it's just normal input field - Set `offset` value as const `0` and not making it customizable (cause why would you want to start searching from ex. 3rd album instead of beginning, right?) - Leaving `Fetching releases from...` notification cause it looks cool - it's fun to know how many followed artists you have π * add: go formatting to the pipeline (#1574) * add: go formatting to the pipeline * formatted missing files * chore: add print for files with bad formatting * fix: specific version fetching in install script (#1578) * chore: enhance specific version fetch (#1582) * fix: specific version fetching in install script * fix: Remove unnecessary request when specifying a version * fix: Allow for input without "v" * No special print for the latest version Instead of printing "Latest version", it prints "Version x.y.z" * chore: better naming of "shortcut" Co-authored-by: FlafyDev <[email protected]> * chore: added community funding option * fix: readme links (#1584) * chore: add bash_profile fallback for bash (#1583) * chore: add bash_profile fallback for bash * applied suggested changes Co-authored-by: wael444 <[email protected]> * revert part of the suggested changes Co-authored-by: wael444 <[email protected]> * fix(windows): add missing prefs message (#1571) * fix: patch prefs on windows * fix: fix type mismatch * fix: `New Releases` custom app for Spotify 1.1.81+ (#1563) * Fix `New Releases` custom app for Spotify 1.1.81+ - Based on proposed fix for `Shuffle+` (#1559) - Fixes #1539 #1530 Notes: - Can probably be written nicer - this is my scuffed attempt to fix it - May or may not actually show all new releases for all followed artists - have over 665 of them but I don't think I'm getting all of them (see below) - May or may not return `error 500` (added `.catch()` block keeps it from breaking whole custom app) * Minimize `internal server error: 500`... ...for big libraries of followed artists. Changes: - Change `URL` to query only discographies - Limit amount of queried albums to 5 Notes: - This does **NOT** fixes erroring fully - it only maxes out amount of data you can query before getting rate limited - The more options you select (ex. albums + EPs + podcasts), the less data you may receive - To max number of albums received, I recommend to select only `Albums` (since `Singles and EPs` will probably get displayed anyway...) * Add notifications when error occurred Notifications added: - Error code (`500`, `429` etc.) - Amount of followed artists to fetch releases from - Amount of followed artists failed to fetch releases from I guess we have to get along with getting `500-ed` - one time it fetches everything instantly, second time it drops 60 artists... * "Prettify" file to pass `Prettier` test * Fix filtering, counter... - Fixing filtering as no matter was what set in config, it always displayed everything as "Album" - Fixing "Missing releases from..." counter - should properly reset now What broke again: - "Appears on" releases cannot be retrieved with that API endpoint - this filter is just there and doesn't do anything - this prevents from showing everything as "Appears on" etc. Notes: - There seem to be an API endpoint for retrieving "Related content" stuff - problem is that would query everything TWICE... which breaks everything even more (and we don't wanna do that) - If someone knows how to query everything using separate endpoint without doing it 4 times, let me know... * Forgor `( )`... Oops... π I forgor π * Include requested changes Changes: - Properly encode URI including variables - Make `limit` variable customizable via settings (set default to 5) - Make error messages as "dev console only" Notes: - Errors displayed in console may be a little spammy - if we get error early, there may be lots of lines displaying it + counter... * I'm not too sure how to tackle this - just remove them altogether? Or is there a function that could "suppress" them? * Switching from normal `log` to `debug` may help a little as they will be only visible if user has set their console log level to include `Verbose` - Making `limit` customizable may lead to even more errors but fuck it I guess - it's better to have a choice than not, right? * It can be manually input via custom app settings (same place where other options are) - there is no list etc. - it's just normal input field - Set `offset` value as const `0` and not making it customizable (cause why would you want to start searching from ex. 3rd album instead of beginning, right?) - Leaving `Fetching releases from...` notification cause it looks cool - it's fun to know how many followed artists you have π * add: go formatting to the pipeline (#1574) * add: go formatting to the pipeline * formatted missing files * chore: add print for files with bad formatting * style(utils/config): make file prettier Signed-off-by: ririxidev <[email protected]> * run go fmt Co-authored-by: Εukasz Ordon <[email protected]> Co-authored-by: Afonso Jorge Ramos <[email protected]> Co-authored-by: ririxidev <[email protected]> * fix(new-releases): switch to `wg://` protocol (#1590) * fix(lyrics): switch to `wg://` protocol (#1587) * fix: change protocol to wg:// * Fixes issues with getting spotify lyrics on lyrics-plus & popupLyrics * Add @ts-nocheck on popupLyrics Fixes #1566 * style: change wording when no lyrics * Update Extensions/popupLyrics.js Co-authored-by: Afonso Jorge Ramos <[email protected]> * fixed prettier error Co-authored-by: Afonso Jorge Ramos <[email protected]> * fix: Fix hooks for Spotify 1.1.83 (#1600) * Fix (New-Releases) : Cards Being Displayed Incorrectly (#1606) Due to the CSS Change In 1.1.83+, song cards were being displayed incorrectly. * fix(devtools): use new method to enable devtools (#1613) * Update css-map.json with latest main-trackInfo-* (#1610) * fix(devtools): overwrite homePath if snap detected (#1614) * fix: modify filePath from .config to .cache (#1618) Co-authored-by: ririxi <[email protected]> * fix(keyboardShortcut): update selector (#1617) * fix queue shortcut * change to double quote * feat(restart): check if process is running (#1623) * fix: Lyrics Plus not showing full lyrics (#1627) * fix(lyrics-plus): add null check (#1630) * fix(lyrics-plus): switch to `wg://` protocol for colors (#1631) * fix(wrapper): adapt few functions to `wg://` protocol (#1632) * fix: adapt urls in custom app & extensions to `wg://` protocol (#1633) * chore(lyrics-plus): use DOMParser to parse the genius (#1636) * fix(devtools): patch another location (#1647) * fix(sidebar-config): get elements by classname (#1654) * Hook patch for react_element regex Co-authored-by: wael444 <[email protected]> Co-authored-by: Afonso Jorge Ramos <[email protected]> Co-authored-by: huhridge <[email protected]> Co-authored-by: Moulick Aggarwal <[email protected]> Co-authored-by: kwerdenker <[email protected]> Co-authored-by: Εukasz Ordon <[email protected]> Co-authored-by: FlafyDev <[email protected]> Co-authored-by: The Blob SCP <[email protected]> Co-authored-by: ririxidev <[email protected]> Co-authored-by: itsmeow <[email protected]> Co-authored-by: ExHigh <[email protected]> Co-authored-by: Julien <[email protected]> Co-authored-by: Kafva <[email protected]> Co-authored-by: ajiou <[email protected]> Co-authored-by: Nam Anh <[email protected]> Co-authored-by: Jeroen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
π Have you checked Spicetify.app page for your issue?
π Is there already an issue for your problem?
βΉ Environment / Computer Info
π Description
New Releases custom app is loading indefinitely.
πΈ Screenshots
No response
The text was updated successfully, but these errors were encountered: