Fix #8549: i18n: -D gettext_compact=0 is no longer working
#8556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since 1bf7fe4, ``-D gettext_compact=0`` is not treated as disabling the feature. It is recognized as creating ``0.pot`` because its type is Any. This changes it to `[bool, str]`.
tk0miya
force-pushed
the
8549_gettext_compact=0
branch
from
7fe9ec7 to
1977f3f
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature or Bugfix
Purpose
-D gettext_compact=0is not treated as disablingthe feature. It is recognized as creating
0.potbecause its type isAny. This changes it to
[bool, str].