Update karma dependency for JS tests #5295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #5295 +/- ##
=======================================
Coverage 82.21% 82.21%
=======================================
Files 296 296
Lines 39346 39346
Branches 6058 6058
=======================================
Hits 32349 32349
Misses 5669 5669
Partials 1328 1328Continue to review full report at Codecov.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed here.
The version of the Karma test runner we use for JS unit tests has dependencies with low-moderate security vulnerabilities. This is not a security issue for Sphinx, because Sphinx does not include these dependencies in any release. But anyway, as Karma has now updated the corresponding dependencies, we should update our Karma version.
Relates