allow search hits in body text that are in title of other doc #2891 #2971
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tk0miya
requested changes
Sep 29, 2016
| @@ -397,7 +397,9 @@ def stem(word): | |||
| # again, stemmer must not remove words from search index | |||
| if not _filter(stemmed_word) and _filter(word): | |||
| stemmed_word = word | |||
| if stemmed_word not in self._title_mapping and _filter(stemmed_word): | |||
| already_indexed = self._title_mapping.get(stemmed_word)\ | |||
| and docname in self._title_mapping.get(stemmed_word) | |||
There was a problem hiding this comment.
I think docname in self._title.mapping.get(stemmed_word, []) is a bit simple.
| @@ -420,6 +420,7 @@ var Search = { | |||
| // now check if the files don't contain excluded terms | |||
| for (file in fileMap) { | |||
| var valid = true; | |||
| //fileMap[file] = $.unique(fileMap[file]); | |||
|
@shibukawa Do you have any opinion about this case? |
|
@tk0miya Thanks for the feedback! Worked it in. |
tk0miya
approved these changes
Oct 4, 2016
|
If no comments until this weekend, I will merge this. |
|
Merged. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.