Improve testing for copyright year substitution #12950
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AA-Turner
commented
Oct 3, 2024
Comment on lines
+160
to
+161
| def test_correct_year_app(expect_date, tmp_path, make_app): | ||
| # integration test |
There was a problem hiding this comment.
Of interest, pycharm reports that this single test takes ~471ms. All 45 tests in the file take 473ms -- goes to show that we should prefer unit tests when possible!
|
Thanks @AA-Turner - this coverage looks good and makes sense to me (particularly the coverage for replacement of future-years and non-system-clock years, helpful to make the changes in #12516 comprehensible) 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @jayaddison
A