Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: add note on unsupported include directive for source-read event content modification #10774

Closed
wants to merge 1 commit into from

Conversation

QSchulz
Copy link

@QSchulz QSchulz commented Aug 17, 2022

Subject: doc: add note on unsupported include directive for source-read event content modification

Purpose

  • Files included with the include directive have their content available
    in the source-read event but modifications will not make it to the
    output, so let's document it.

Relates

Note

Does this need to be sent to master and/or 4.x branch too?

…content modification

Files included with the `include` directive have their content available
in the source-read event but modifications will not make it to the
output, so let's document it.

Closes sphinx-doc#10678
Signed-off-by: Quentin Schulz <[email protected]>
@AA-Turner AA-Turner changed the base branch from 5.x to master October 16, 2022 15:27
@AA-Turner AA-Turner added this to the some future version milestone Apr 29, 2023
@halldorfannar
Copy link
Contributor

halldorfannar commented Aug 22, 2023

@AA-Turner I believe this PR can be closed now since the root issue has been resolved and fix merged into master.

@QSchulz
Copy link
Author

QSchulz commented Aug 22, 2023

Or we could add a note stating that there is a limitation for included files until version X.Y.

@AA-Turner AA-Turner closed this Jul 14, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants