Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #178
1. Move
asyncio.Event
creation to lifespanThis PR moves the creation of the
asyncio.Event
fromRebuildServer.__init__
toRebuildServer.lifespan
. This ensuresasyncio.Event
is created within the event loop context, resolving the relevant error.Note
The error does not occur in Python>=3.10 because the implementation was changed by python/cpython#86558.
2. Add rebuild test
Since there was no rebuild test, I added one.
refresh
messages from/websocket-reload
after modifying theindex.rst
file.TestClient
uses threads, whileRebuildServer
uses multiprocessing. In my view, this affected the rebuild test execution and cause it to fail. (0662fc9)TestClient
tohttp.AsyncClient
. (ref)asgi-lifespan
andhttpx-ws
required for testing lifespan and WebSocket.