align and caption #40
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12rambau
requested changes
Mar 26, 2024
There was a problem hiding this comment.
I checked the pre-build and it seems wrapping the video tags in a div is defaulting to center. Can you make sure that default remains consistently to the left ?
Can you add an example for each alignement so the users can feel the difference (and we can visually check it works as expected) ?
Can you regenerate the tests, adding the div is breaking every build.
berlin2123
commented
Mar 27, 2024
12rambau
requested changes
Nov 5, 2024
Comment on lines
+115
to
+116
| For consistency with previous versions, which not support align, the default value of align 'left' when the it is not set. | ||
| If you want to use the 'default' defined by theme, you need to, manually, set it to 'default': |
There was a problem hiding this comment.
Suggested change
| For consistency with previous versions, which not support align, the default value of align 'left' when the it is not set. | |
| If you want to use the 'default' defined by theme, you need to, manually, set it to 'default': | |
| For consistency with previous versions, which not support align, the default value of align is set to `left` when nothing is set. | |
| If you want to use the alignment defined by your theme, you need to, manually, set it to `default`: |
12rambau
requested changes
Nov 5, 2024
There was a problem hiding this comment.
@berlin2123 sorry for the long wait, all my OSS time was eaten up by another project. I would like to move forward with your PR, could you rebase it with the current main so I can merge it in the next release ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add align and caption.
related to : #38 #39