Implement compatibility with Towncrier >= 22.12.0rc1
#75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I wouldn't drop support for all the older versions, meaning this needs compat shims that would satisfy the CI matrix as well as a test case for future compatibility. |
Codecov Report
@@ Coverage Diff @@
## master #75 +/- ##
==========================================
+ Coverage 50.00% 50.51% +0.51%
==========================================
Files 9 9
Lines 188 196 +8
Branches 24 25 +1
==========================================
+ Hits 94 99 +5
- Misses 93 96 +3
Partials 1 1 |
webknjaz
reviewed
Dec 21, 2022
webknjaz
reviewed
Dec 21, 2022
webknjaz
reviewed
Dec 21, 2022
webknjaz
reviewed
Dec 22, 2022
webknjaz
reviewed
Dec 22, 2022
webknjaz
reviewed
Dec 22, 2022
webknjaz
reviewed
Dec 22, 2022
webknjaz
reviewed
Dec 22, 2022
davfsa
reviewed
Dec 22, 2022
webknjaz
requested changes
Dec 22, 2022
webknjaz
approved these changes
Dec 22, 2022
webknjaz
force-pushed
the
fix-towncrier22.12.0
branch
2 times, most recently
from
bdf25de to
1db6ca1
Compare
This is a compatibility change needed for Towncrier >= 22.12.0rc1 after it changed the internal object to be a `dataclass`. Refs: * twisted/towncrier#429 * twisted/towncrier#461 Resolves sphinx-contrib#76. Co-Authored-By: davfsa <[email protected]> Co-Authored-By: Sviatoslav Sydorenko <[email protected]>
This is necessary as a compatibility improvement after the said function arguments got renamed but the order stayed the same. Ref: twisted/towncrier#429
webknjaz
force-pushed
the
fix-towncrier22.12.0
branch
from
1db6ca1 to
7cb2716
Compare
webknjaz
changed the title
Towncrier >= 22.12.0rc1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes breaks because of twisted/towncrier#429