-
-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: set concurrency #112
CI: set concurrency #112
Conversation
I don't really understand what tox-gh brings, beyond duplicating the Python version numbers in test.yml and in tox.ini Please could you elaborate on the benefits? |
You are probably right, just found it easier to read/follow... |
I'm not a fan of bringing yet another dependency here. If it was me alone I would just have a single github build (with multiple actions/setup-python in it, yes it works) running a single tox instance: trying to keep it simple, a bit like in 45af71c. |
Yes, agree but since the Tox is here, it is better to check it and the simplest was to do so is use it... So to say reduce dead code =)
Well, this one is also strange with redundant python setups... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Anyway, back to this PR.
I think the concurrency:
changes are useful, and let's revert the others.
OK will update PR and it's name accordingly |
Co-authored-by: Hugo van Kemenade <[email protected]>
Co-authored-by: Hugo van Kemenade <[email protected]>
Co-authored-by: Hugo van Kemenade <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
@hugovk so fine to land? 🐿️ |
@hugovk is it fine now, or shall I update something else? 🦩 |
Found this use-case for GH action and Tox - https://github.com/tox-dev/tox-gh; what do you think?