-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gracefully handle if git is not installed #229
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice fix, thank you!
Hi @dhellmann, is this blocked on the failing tests? They appear to be an unrelated issue with xmlrpc. |
Yes, we will have to remove the use of the plugin that relies on that old XMLRPC interface so the tests work. I'm pretty sure that just means changing this line to set the flag to False |
The "History Update" job is failing because there is no corresponding change in history.rst explaining this fix. |
I added a history entry. For the XML issue, it appears to be an issue in this package here: https://github.com/sphinx-contrib/spelling/blob/main/sphinxcontrib/spelling/filters.py#L165-L166 |
I missed that the XML bug is an open issue here as well #227 |
@Mergifyio rebase |
The following error occurs in `_get_contributors()` if git is not installed. > FileNotFoundError: [Errno 2] No such file or directory: 'git': 'git' Treat this the same as if `git` fails, catch the error and print a warning.
✅ Branch has been successfully rebased |
bb2bd37
to
7b10eea
Compare
This fix is included in release 8.0.1. Thank you! |
The following error occurs in
_get_contributors()
if git is not installed.Treat this the same as if
git
fails, catch the error and print a warning.