Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import ExtensionError from primary module. #1

Merged
merged 1 commit into from
Jul 5, 2022

Conversation

jelmer
Copy link
Collaborator

@jelmer jelmer commented Feb 3, 2019

Import ExtensionError from primary module.

It is no longer imported into sphinx.application in newer versions.

It is no longer imported into sphinx.application in newer versions.
@surgan12
Copy link

What about this, when will get merged ?

@thclark
Copy link
Collaborator

thclark commented Aug 13, 2020

+1 for merging this. It's one click! Please @maintainers?

orenhecht added a commit to orenhecht/googleanalytics that referenced this pull request Dec 30, 2020
Github doesn't play nice so applying these manually:
sphinx-contrib#1
sphinx-contrib#3
@jelmer
Copy link
Collaborator Author

jelmer commented Aug 25, 2021

FWIW "pip install git+https://github.com/jelmer/googleanalytics" will install the version from my repository to work around the issue for the moment, but of course it would be much better to have this is the main branch.

@thclark
Copy link
Collaborator

thclark commented Aug 26, 2021

I just asked for maintenance access here so we can resurrect this.
@jelmer and @orenhecht you could do the same to accelerate things if you have other updates at any point.

@jelmer jelmer merged commit a38bbac into sphinx-contrib:master Jul 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants