Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lint updates #1074

Merged
merged 4 commits into from
Jan 18, 2025
Merged

Lint updates #1074

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
fed64c8
lint: update ruff to v0.9.2
jdknight Jan 18, 2025
116ec7e
lint: update pylint to v3.3.3
jdknight Jan 18, 2025
bc87f4a
lint: fix mypy to v1.14.1
jdknight Jan 18, 2025
054f809
util: update suffix logic to modern calls
jdknight Jan 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions sphinxcontrib/confluencebuilder/util.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,12 +79,12 @@ def normalize_base_url(url):
if url:
# removing any trailing forward slash user provided
if url.endswith('/'):
url = url[:-1]
url = url.removesuffix('/')
# check for rest api prefix; strip and return if found
if url.endswith(API_REST_V1):
url = url[:-len(API_REST_V1)]
url = url.removesuffix(API_REST_V1)
if url.endswith(API_REST_V2):
url = url[:-len(API_REST_V2)]
url = url.removesuffix(API_REST_V2)
# restore trailing forward flash
elif not url.endswith('/'):
url += '/'
Expand Down
6 changes: 3 additions & 3 deletions tox.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ commands = {envpython} -m sphinx -M latexpdf . _build -E -a
[testenv:pylint]
deps =
{[testenv]deps}
pylint: pylint==3.3.1
pylint: pylint==3.3.3
commands =
pylint \
sphinxcontrib \
Expand All @@ -67,7 +67,7 @@ commands =
[testenv:ruff]
deps =
{[testenv]deps}
ruff: ruff==0.8.1
ruff: ruff==0.9.2
setenv =
{[testenv]setenv}
RUFF_CACHE_DIR={toxworkdir}/.ruff_cache
Expand All @@ -82,7 +82,7 @@ commands =
deps =
{[testenv]deps}
-r{toxinidir}/requirements_types.txt
mypy
mypy: mypy==1.14.1
commands =
mypy \
--explicit-package-bases \
Expand Down
Loading