Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Magnetic space group identification and standardization #41

Merged
merged 18 commits into from
Jan 20, 2025
Merged

Magnetic space group identification and standardization #41

merged 18 commits into from
Jan 20, 2025

Conversation

lan496
Copy link
Member

@lan496 lan496 commented Dec 27, 2024

This includes a lot of breaking changes

@codecov-commenter
Copy link

codecov-commenter commented Dec 27, 2024

Codecov Report

Attention: Patch coverage is 96.82203% with 30 lines in your changes missing coverage. Please review.

Project coverage is 90.02%. Comparing base (a631f87) to head (c315c6e).
Report is 21 commits behind head on main.

Files with missing lines Patch % Lines
moyo/src/identify/magnetic_space_group.rs 95.65% 12 Missing ⚠️
moyo/src/base/magnetic_cell.rs 41.66% 7 Missing ⚠️
moyo/src/identify/point_group.rs 96.62% 3 Missing ⚠️
moyo/src/data/magnetic_space_group.rs 90.47% 2 Missing ⚠️
moyo/src/data/setting.rs 75.00% 2 Missing ⚠️
moyo/src/base/operation.rs 97.29% 1 Missing ⚠️
moyo/src/data/hall_symbol.rs 95.00% 1 Missing ⚠️
moyo/src/identify/rotation_type.rs 94.11% 1 Missing ⚠️
moyo/src/search/solve.rs 92.85% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #41      +/-   ##
==========================================
+ Coverage   87.83%   90.02%   +2.19%     
==========================================
  Files          38       42       +4     
  Lines        5014     5594     +580     
==========================================
+ Hits         4404     5036     +632     
+ Misses        610      558      -52     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lan496 lan496 added the breaking-changes Incompatible with patch release label Jan 11, 2025
@lan496 lan496 mentioned this pull request Jan 11, 2025
4 tasks
@lan496 lan496 changed the title [WIP] Magnetic space group support [WIP] Magnetic space group identification Jan 11, 2025
@lan496 lan496 force-pushed the msg branch 3 times, most recently from 9ff63ad to 746daef Compare January 11, 2025 01:32
@lan496 lan496 changed the title [WIP] Magnetic space group identification Magnetic space group identification Jan 20, 2025
@lan496 lan496 changed the title Magnetic space group identification Magnetic space group identification and standardization Jan 20, 2025
@lan496 lan496 marked this pull request as ready for review January 20, 2025 11:14
@lan496 lan496 merged commit ee16b2d into main Jan 20, 2025
16 checks passed
@lan496 lan496 deleted the msg branch January 20, 2025 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-changes Incompatible with patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants