Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip lattice reduction in standardizing triclinic structures #36

Merged
merged 1 commit into from
Dec 21, 2024

Conversation

lan496
Copy link
Member

@lan496 lan496 commented Dec 21, 2024

Closes #35

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 88.88889% with 1 line in your changes missing coverage. Please review.

Project coverage is 89.19%. Comparing base (a2e152f) to head (4da55cc).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
moyo/src/base/lattice.rs 87.50% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #36      +/-   ##
==========================================
- Coverage   89.38%   89.19%   -0.19%     
==========================================
  Files          32       32              
  Lines        4530     4534       +4     
==========================================
- Hits         4049     4044       -5     
- Misses        481      490       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lan496 lan496 merged commit 8d4282b into main Dec 21, 2024
16 checks passed
@lan496 lan496 deleted the fix-niggli branch December 21, 2024 03:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Niggli reduction failure for WBM dataset with small symprec
2 participants