Fix #186 store unknown flags #187
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
There is still a bug where the last argument is unknown and the "--name value" syntax is used rather than the "---name=value" syntax. I will fix this |
amterp
added a commit
to amterp/rad
that referenced
this pull request
Nov 23, 2024
Unfortunately pflag does not let you get the ignored args, it just tosses them away. In order for this feature to work, I'd need to dump pflag as well and really do my own parsing. I don't really wanna do that. This feature is not important enough, especially because you can relatively easily have your own string[] 'rest' arg which you can then join with spaces and offer as passthrough, with the downside of expecting users to comma separate their args. Some pflag Github discussions: spf13/pflag#160 spf13/pflag#187 spf13/pflag#186
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For review. First attempt at addressing #186.