Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Misc number updates #140

Merged
merged 3 commits into from
May 11, 2022
Merged

Misc number updates #140

merged 3 commits into from
May 11, 2022

Conversation

bep
Copy link
Collaborator

@bep bep commented May 11, 2022 •
edited
Loading

No description provided.

@bep bep mentioned this pull request May 11, 2022
Closed
@bep bep force-pushed the feat/misc-int branch 3 times, most recently from 4fa8b68 to 0932956 Compare May 11, 2022 13:16
@bep
Misc number fixes
9a419b0 
* Allow strings/json.Number with just zeroes after the decmial point to be converted to integer`
* Allow nil in ToFloat*
* Remove some test duplication
* replace testify with quicktest
* Enable integer and float conversion of time.Weekday values

Fixes spf13#139
Fixes spf13#141
@bep bep force-pushed the feat/misc-int branch from 0932956 to 9a419b0 Compare May 11, 2022 13:41
@bep bep merged commit 2b0eb0f into spf13:master May 11, 2022
@morrisxyang morrisxyang mentioned this pull request Mar 8, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bep @yveshield