Added option for disabling watch-only notification #8133
Conversation
|
I think there is a real risk of a casual user creating a wallet from an address and not realising it's watch-only. They might have previously selected "don't show again" for another wallet, in which case they would not get a warning anymore. I suppose if you use a watch-only wallet on a regular basis it might become a nuisance to always get the popup... I imagine that's your motivation, right? Maybe we could add the "don't show" option on a per-wallet basis (save into wallet file instead of config?). Even then, people might forget that a wallet is watching-only. :/ And re exposing the option in the Preferences, that seems overkill. People who would hide the warning in the first place would not likely re-enable it later IMO. |
| checkbox.stateChanged.connect(partial(checkboxStateChanged, result=result)) | ||
| self.show_warning(msg, title=_('Watch-only wallet'), checkbox=checkbox) | ||
| if result.isChecked == Qt.Checked: | ||
| self.config.set_key('disable_watch-only_warning', True, save=True) |
There was a problem hiding this comment.
Nit but I would prefer not using dashes in config keys. atm IIRC they all use snake-case, and we should keep it consistent. Just convert any - to _.
|
I thought about that and found it is not a serious problem because worst thing that happens is: You cannot send. And then you very likely remember why :) Also: I had the idea to add "Watch-only Wallet" in the title bar of the main window. That way people who don't remember turning off watch-only-warning can still see this anytime. |
Some people create imported wallets from random addresses they find on forums/etc, to monitor their history. If they mistakenly hand those out to receive on, the money is lost to them (as the address belongs to someone else).
That's already there: electrum/electrum/gui/qt/main_window.py Line 535 in 10e7d8d |
You are right, that's a little bit more safe.
Ok, that's true. What about a warning message in case a user tries to create a payment request for a watch-only wallet? Would you then feel comfortable adding this feature? If not, please comment/close issue #2835.
Uhm yeah, didn't even check, sorry :) |
|
The popup is also a protection against some attacks. There have been reports of users having a watching-only wallet maliciously installed on their computer. It is a very cheap attack, requires no programming skills. Someone with unauthorized access to a computer would certainly disable that popup too.
No, it is not that you did not check, but that you did not see it. |
Indeed, good point. I still think that it can be annoying for advanced users to always quit that popup. Another idea:
That way people who use Electrum for checking balances of cold wallets can turn off the annoying popup at app start, but inattentive users won't get scammed so easily. |
This fixes #2835.
I added a checkbox in the warning dialog to disable the warning, also added the option in Preferences -> Misc to toggle it.