mnemonic: make sure newly generated seeds are not valid as bip39 #6001
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently there is an approx 1/16 chance that newly generated seeds have a valid bip39 checksum (and hence are both valid electrum seeds and bip39 seeds at the same time).
This patch would make sure that newly generated seeds are not also valid bip39 seeds by accident.
As a result, seed generation would become a bit slower, taking approx. 20% more time.