Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to process common plain files directly #146

Merged
merged 25 commits into from
Nov 21, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
58fe208
Allow to process XML and JSON directly
spekulatius Nov 10, 2022
40c3bb1
Move `testNullPassingThrough` to the top
spekulatius Nov 10, 2022
a120c96
Improve test coverage by ensuring baseHref is considered for `makeUrl…
spekulatius Nov 10, 2022
6cf3489
Improve test logic
spekulatius Nov 10, 2022
ef6f13e
Tidy up core
spekulatius Nov 10, 2022
a02e7e8
Split test files
spekulatius Nov 12, 2022
d5ab34a
wip
spekulatius Nov 12, 2022
7c5f2a8
Merge branch '139-csv-and-other-file-types' of github.com:spekulatius…
spekulatius Nov 13, 2022
08569ad
rm original test
spekulatius Nov 13, 2022
6474ae2
rm static callers
spekulatius Nov 14, 2022
95baed7
adding ct
spekulatius Nov 14, 2022
0daf695
Keep original name
spekulatius Nov 14, 2022
23d4b49
Implement some CSV base methods
spekulatius Nov 14, 2022
163efcf
rm trailing slash
spekulatius Nov 14, 2022
b79130f
Progressing basic CSV parsers
spekulatius Nov 14, 2022
7081e80
Better type casting
spekulatius Nov 14, 2022
719044f
Progressing CSV parsers
spekulatius Nov 15, 2022
26b18ed
Adding documentation page for file parsing
spekulatius Nov 20, 2022
399da3f
Undo to keep PRs more specific
spekulatius Nov 20, 2022
d69dadc
Tidy up doc page
spekulatius Nov 21, 2022
cb600bc
Add separator, enclosure & escape support, tests and doc
spekulatius Nov 21, 2022
3705d1a
Fix filename
spekulatius Nov 21, 2022
9bcf8fb
Tweak docu
spekulatius Nov 21, 2022
1c4b2b2
Improve title
spekulatius Nov 21, 2022
885ed14
Final tweaks on documentation page
spekulatius Nov 21, 2022
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,8 @@
}
},
"scripts": {
"test": "./vendor/phpunit/phpunit/phpunit --cache-result --cache-result-file=/tmp --order-by=defects --colors=always --stop-on-failure"
"test": "./vendor/phpunit/phpunit/phpunit --cache-result --cache-result-file=/tmp --order-by=defects --colors=always --stop-on-failure",
"ct": "while true; do composer run test; sleep 30; done"
},
"funding": [
{
Expand Down
22 changes: 11 additions & 11 deletions src/Core.php
Original file line number Diff line number Diff line change
Expand Up @@ -3,38 +3,38 @@
namespace spekulatius;

/**
* This class organizes mostly. For individual functionality please check the related traits.
* This class organizes mostly. For individual functionality check the related traits please.
*/

class Core
{
/**
* Shared simple parsers.
*/
use UsesParsers;

/**
* Url related helpers.
* Url related helpers for information about the current location and URL processing.
*/
use UsesUrls;

/**
* This trait manages Goutte itself.
* This trait manages the interaction with Goutte.
*/
use UsesGoutte;

/**
* This contains the basic filter methods.
* This contains the basic filter methods. Make accessing data easier.
*/
use UsesXPathFilters;

/**
* This contains various content-related selectors.
* This contains various content-related selectors. meta tags, h1, etc. pp.
*/
use UsesContent;

/**
* This contains the feeds-related selectors and parsers.
* Shared simple parsers for XML, JSON and CSV.
*/
use UsesParsers;

/**
* This contains the feeds-related selectors and parsers: RSS, sitemap, search index, etc.
*/
use UsesFeeds;
}
Loading