Feat: Add Logo #68
Merged
Feat: Add Logo #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I checked the AppVeyor project and it has the icon file and the nuspec looks good too. |
|
@codito Apparently I can't assign you as a reviewer on this project. |
codito
reviewed
Sep 17, 2020
| @@ -17,4 +17,11 @@ | |||
| <PackageReference Include="Microsoft.TestPlatform.ObjectModel" Version="15.5.0" /> | |||
| <PackageReference Include="System.ValueTuple" Version="4.3.0" /> | |||
| </ItemGroup> | |||
|
|
|||
| <ItemGroup> | |||
| <PackageReference Update="Stylecop.Analyzers" Version="1.1.118"> | |||
There was a problem hiding this comment.
Stylecop should be updated in scripts/dependencies.props
There was a problem hiding this comment.
Ah, got it. I was surprised to see stylecop was added to these csproj files but wasn't sure where else it should have happened.
Merged
codito
approved these changes
Sep 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add logo.