-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
exception in action results in green test #176
Comments
Hm... I realised that it also happens if one of the test fails. Am I using describe("throws an exception") {
throw IllegalArgumentException("oh no...")
}
describe("should be executed nonetheless") {
it("should be green") {}
} |
@robstoll It's a limitation of the plugin, unfortunately (raniejade/spek-idea-plugin#29). If you're using gradle everything should work as expected. I'm looking into ways to fixing this, but it might take a while. |
@raniejade you are right, it works fine in gradle, at least my first concern (described in the issue). However, my second concern (described in my comment) still holds. If an unexpected exception occurs in a group scope then none of the tests are executed. Is this intentional? |
@robstoll No, it's not. Re-opening the ticket, it should still continue and just ignore the failing group. |
Ignore failing groups during discovery phase. Passing groups will now be properly discovered by Spek. Resolves #176.
Awesome, when is your next release planned? |
The error can be reproduced by the following code:
The
on
should not be green (I am using intellij) but red and an exception should be shown.The text was updated successfully, but these errors were encountered: