add V1ClusterProfilesUIDSpcDownload API #149
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devang-gaur
force-pushed
the
add_V1ClusterProfilesUIDSpcDownload
branch
2 times, most recently
from
ccc2952 to
524cc9b
Compare
TylerGillson
requested changes
Feb 12, 2025
devang-gaur
force-pushed
the
add_V1ClusterProfilesUIDSpcDownload
branch
from
4a07b42 to
e497d7f
Compare
TylerGillson
requested changes
Feb 14, 2025
devang-gaur
force-pushed
the
add_V1ClusterProfilesUIDSpcDownload
branch
from
e497d7f to
88c8830
Compare
devang-gaur
force-pushed
the
add_V1ClusterProfilesUIDSpcDownload
branch
from
88c8830 to
c1a99f3
Compare
devang-gaur
force-pushed
the
add_V1ClusterProfilesUIDSpcDownload
branch
from
c1a99f3 to
68494d6
Compare
TylerGillson
requested changes
Feb 14, 2025
| params := clientv1.NewV1ClusterProfilesUIDSpcDownloadParamsWithContext(h.ctx). | ||
| WithUID(profileUID) | ||
|
|
||
| resp, err := h.Client.V1ClusterProfilesUIDSpcDownload(params, w) |
There was a problem hiding this comment.
This method returns an io.ReadCloser we need to actually read from it into a buffer and save the resulting data somewhere.
There was a problem hiding this comment.
my plan is to consume it like this
kind of like this in the stylus repo
https://github.com/spectrocloud/stylus/blob/7b29a7e908627516135c003e17ac988e7cd45750/pkg/services/spectro-cli/cmd/spectro-cli-build.go#L319
There was a problem hiding this comment.
Ok. ExportClusterProfile returns a bytes.Buffer and DownloadLogs returns an io.Writer. It would be good to standardize these.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.