Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat 51 name first level of list #83

Merged
merged 8 commits into from
Jun 3, 2023
Merged

Feat 51 name first level of list #83

merged 8 commits into from
Jun 3, 2023

Conversation

philipp-baumann
Copy link
Member

addresses #51

@philipp-baumann philipp-baumann force-pushed the feat-51-name-first-level-of-list branch from 8d875d3 to 148b383 Compare May 7, 2023 22:35
@philipp-baumann philipp-baumann mentioned this pull request May 7, 2023
Closed
philipp-baumann and others added 3 commits May 20, 2023 00:39
@philipp-baumann
merge current master
6977265 
Merge branch 'main' into feat-51-name-first-level-of-list
# Please enter a commit message to explain why this merge is necessary,
# especially if it merges an updated upstream into a topic branch.
#
# Lines starting with '#' will be ignored, and an empty message aborts
# the commit.
@pre-commit-ci-lite
[pre-commit.ci lite] apply automatic fixes
8cdc061
@philipp-baumann
only use DSN file name for naming "list_opusreader2" class elements
b3b5037
@philipp-baumann
Copy link
Member Author

philipp-baumann commented Jun 2, 2023 •
edited
Loading

@laura-summerauer @ThomasKnecht FYI b3b5037 reduces the naming of the "list_opusreader2" elements to the very basic. This means we just use the base file name from the data source name (DSN). Like this we make it easy for any user to filter the read_opus() output simply by file name. If multiple files of the same base name test_file.0, i.e. those OPUS files lay in different subdirectories, are read, then data["test_file.0"] is the easiest way to select all those files.

@philipp-baumann philipp-baumann merged commit 2bd795e into main Jun 3, 2023
@philipp-baumann philipp-baumann deleted the feat-51-name-first-level-of-list branch June 3, 2023 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ThomasKnecht ThomasKnecht Awaiting requested review from ThomasKnecht

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@philipp-baumann