Feature collections #90
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed up code alignment in README.md
Any `EXPBlockDefinedMatcher` effectively ignores the argument passed to `matches:` and instead fetches the `actual` from it's instance with `self.actual`. This adds mental overhead and makes @ollieatkinson 's work on enabling a syntax similar to `expect(@[ @1, @2]).elements.to.equal(1)` for collections messy.
This method seems to add unnecessary complication to the calling convention and appears to only have originally existed to allow for Async testing. The `to:(NSObject **)actual` parameter in `-[EXPExpect applyMatcher:to:]` appears to only have existed for the purpose of being a flag to say “we have a value now” - this is no longer required with the fixes from the previous commit.
Some matchers like `EXPMatchers+notify` are currently using `failureMessageForTo` and `failureMessageForNotTo` to signify the end of the expectation and perform any clean up such as unregistering for notifications. This prevents the matcher from being reused. By adding an explicit cleanUpBlock the matcher can safely do whatever clean up it needs to do and know that it is not going to be used again from that point.
NSArray *array = @[ @1, @2, @1, @3 ]; expect(array).elements.to.equal(@1); //=> (1)=> expected: 1, got: 2, (3)=> expected: 1, got: 3 NSSet *set = [NSSet setWithArray:array]; expect(array).elements.to.equal(@1); //=> (element)=> expected: 1, got:2, (element)=> expected: 1, got: 3 * Reduce complexity of `applyMatcher:`
|
How about adding explicit |
|
Could you provide an example? You could easily add syntactic sugar for I'm not so sure |
|
|
|
Here's an implementation that adds |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add collection semantics
Reduce complexity of
applyMatcher: