Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add formMeta menu in "View in Forms" and add unload protect to "Use Localized Field Labels" #5416

Open
wants to merge 12 commits into
base: production
Choose a base branch
from

Conversation

alesan99
Copy link
Contributor

@alesan99 alesan99 commented Nov 25, 2024

Fixes #2514
Expansion of #3594

Adds a formMeta button the "View in Forms" in query results (#3594) and adds an unload protect so toggling Localized Fields in Form Meta doesn't erased unsaved queries

Checklist

  • Self-review the PR after opening it to make sure the changes look good
    and self-explanatory (or properly documented)
  • Add automated tests
  • Add relevant issue to release milestone

Testing instructions

  • Create a new query
  • Run the query and click "Browse in Forms"
  • Check that the form meta button is there
  • Make sure the settings within form meta work as expected
  • Check Unload Protects:
    • Click Form Meta -> Form Definition
    • Click close and make sure no Unload Protect appears
    • Click Form Meta -> Form Definition and toggle "Use Localized Field Labels"
    • Click close and make sure an Unload Protect appears
    • Save the query and try again
    • Click close and make sure no Unload Protect appears
    • Do the same for the Form Meta button in Data Entry

Copy link
Member

@maxpatiiuk maxpatiiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!
good to see few useEffect hooks being removed

@alesan99 alesan99 marked this pull request as ready for review December 3, 2024 15:33
@CarolineDenis CarolineDenis self-requested a review December 6, 2024 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 📋Back Log
Development

Successfully merging this pull request may close these issues.

FormMeta menu is not available in "View in Forms"
3 participants