Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disallow to add rank in create tree dialog #5377

Merged
merged 5 commits into from
Nov 7, 2024
Merged

Conversation

CarolineDenis
Copy link
Contributor

@CarolineDenis CarolineDenis commented Nov 5, 2024

Fixes #5376

Checklist

  • Self-review the PR after opening it to make sure the changes look good
    and self-explanatory (or properly documented)
  • Add relevant issue to release milestone

Testing instructions

Go to taxon tree
Click the add button next to tree name
Click any tree

  • See you cannot add rank using form or table view

@CarolineDenis CarolineDenis added this to the 7.9.8 milestone Nov 5, 2024
@CarolineDenis CarolineDenis changed the title Allow to add rank in create tree dialog Disallow to add rank in create tree dialog Nov 6, 2024
@CarolineDenis CarolineDenis requested review from sharadsw and a team and removed request for emenslin November 6, 2024 16:46
Copy link
Contributor

@pashiav pashiav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing instructions

Go to taxon tree
Click the add button next to tree name
Click any tree

  • See you cannot add rank using form or table view

Looks good! Cannot add tree def items.
Screen Shot 2024-11-06 at 2 05 27 PM
Screen Shot 2024-11-06 at 2 08 02 PM

@pashiav pashiav requested a review from a team November 6, 2024 20:08
@lexiclevenger
Copy link
Collaborator

This also disables the Add button in the Tree Def Items form for existing trees, not just when creating a new Tree Definition. Is this the expected behavior?

Screen.Recording.2024-11-06.164835.mp4

@CarolineDenis
Copy link
Contributor Author

@lexiclevenger, yes

@CarolineDenis CarolineDenis removed the request for review from a team November 7, 2024 14:27
@CarolineDenis CarolineDenis merged commit 7fe1b80 into production Nov 7, 2024
12 checks passed
@CarolineDenis CarolineDenis deleted the issue-5376 branch November 7, 2024 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Can add TreeDefItems when creating a new tree
5 participants