Allow test-panel branch instances to run without Specify 6 #122
Conversation
|
We'll need to add a way to check to see if the branch has the config directory in the Specify 7 filesystem from the |
|
Added code to check each branch to see if it has a 'config/' directory. Depending if it does or not, we need to modify the nginx and docker-compose files. I couldn't inspect each branch's docker container before it's created, so instead it just makes a GET request to 'https://github.com/specify/specify7/tree/${branch}/config' to see if the config directory exists for the branch. |
This reverts commit 6527676.
| })); | ||
| const state = await Promise.all( | ||
| rawState.map(async (deployment) => { | ||
| const hasInteralSp7ConfigDirectory = await branchHasConfigDirectory(deployment.branch); |
There was a problem hiding this comment.
this is going to make a lot of network requests to github (setState is called many times per day, and the request is made for each branch)
though I guess this is the least complicated approach
The main change is to edit nginx rewrite for config to static-files volume path. The current solution will require all new branches to have config in the Specify 7 container, instead of in a seperate Specfy 6 container. Further work will be needed in order to support new and old branches where the config location is different for the nginx rewrite path to point to. Need a good way of specifying if a branch uses the new or old config setup.