Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add convertTheory for CommonLogic #2128

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

add convertTheory for CommonLogic #2128

wants to merge 1 commit into from

Conversation

daniilsvc
Copy link
Collaborator

Solve #2110

@daniilsvc daniilsvc requested a review from mcodescu December 8, 2022 08:46
mcodescu
mcodescu reviewed Dec 15, 2022
View reviewed changes
Copy link
Collaborator

@mcodescu mcodescu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good but when I try out the example from the issue, I get

logic CommonLogic.FirstOrder

(cl-comment "name-a" (P a)) (cl-comment "name-b" (P b)) (P c)

Is this still one sentence or is this a problem with the printing?

@tillmo
Copy link
Contributor

tillmo commented Jan 5, 2023

I need to discuss #2133 with @fabianneuhaus first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcodescu mcodescu mcodescu left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@daniilsvc @tillmo @mcodescu