fix!(w3c/style): override color-scheme with meta tag #4700
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcoscaceres
commented
Apr 24, 2024
|
Let's still keep this behind darkMode flag for a while? It was added to prevent specs that use custom styles to opt-in to prevent breaks. |
|
I still don’t feel that a configuration flag is the right approach. It should then be we inject the meta to default to “light”, allowing spec authors to then opt into light/dark. Then the transitional path is that we announce this, and give everyone a year to check their specs before switching to light/dark. |
|
Should be good to go now, @sidvishnoi. |
marcoscaceres
commented
Apr 27, 2024
marcoscaceres
commented
Apr 27, 2024
marcoscaceres
commented
Apr 27, 2024
sidvishnoi
changed the title
sidvishnoi
approved these changes
Apr 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the opt in
respecConfig.darkModeoption, allowing HTML's meta tag to be used instead.