Fix invalid CSS in dfnpanels.css #2735
Conversation
A border-radius was missing a unit
|
Context: I'm seeing spec build failures [0] for [1] (which itself fixes an unrelated spec build failure), and this looked possibly to be the culprit? Not sure since this line is 2 months old though... [0] https://github.com/WICG/turtledove/actions/runs/7173660187/job/19533486675?pr=949 |
|
Reported as #2733 |
Yeah, but it was between two semver changes, so likely wasn't picked up by spec-prod until the 4.0.0 release a few days ago. |
| @@ -71,7 +71,7 @@ | |||
| margin-right: 0.5em; | |||
| width: 0.85em; | |||
| height: 1em; | |||
| border-radius: 3; | |||
| border-radius: 3em; | |||
There was a problem hiding this comment.
Looking at the rendering, this becomes an offset pair of boxes. 3em makes them very round; I suspect we'd do better with px or removing the radius entirely.
| border-radius: 3em; |
|
It's meant to be px, yeah. I've made the change; I'm just rebasing tests real quick and then I'll cut a new release. Sorry about that. |
Add missing unit to border-radius.