Fix aiohttp upgrade #951
Merged
Fix aiohttp upgrade #951
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-first#844)" This reverts commit b2a4287.
Somewhere between 3.5.1 and 3.5.2, the aiohttp reimport started succeeding (in connexion.connexion.cli.run()). It's not clear which change caused the issue, but it's probably one of: - aio-libs/aiohttp#3469 (Remove wildcard imports) - aio-libs/aiohttp#3464 (Don't suppress gunicorn cleanup errors) - aio-libs/aiohttp#3471 (Refactor workers) - aio-libs/aiohttp#3500 (Ignore done tasks) In any case, setting sys.modules['aiohttp'] = None should prevent reimporting it. See: https://stackoverflow.com/a/1350574 I successfully tested locally on py37 with aiohttp 3.5.1 and 3.5.2.
|
Yeah, they some things happening regarding imports and so on. |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix test_run_with_aiohttp_not_installed with aiohttp 3.5.2+.
The error was prevented by requiring
aiohttp<3.5.2in #844.Somewhere between 3.5.1 and 3.5.2, this aiohttp reimport started succeeding.
I used pycharm's debugger to determine that it is this import that was successfully re-importing aiohttp.
https://github.com/zalando/connexion/blob/ff3adb393c67dea51a735ef3211794084db3623e/connexion/cli.py#L151-L155
It's not clear which change caused the issue, but I would guess one of these:
Changes proposed in this pull request:
sys.modules['aiohttp'] = Nonein the test