Custom auth types in security_map #1940
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ruwann
force-pushed
the
fix/custom-security-type
branch
from
e5bf766 to
f949454
Compare
Ruwann
force-pushed
the
fix/custom-security-type
branch
from
523dfd2 to
f701207
Compare
Ruwann
force-pushed
the
fix/custom-security-type
branch
from
f701207 to
1ef1833
Compare
Ruwann
approved these changes
Dec 14, 2024
There was a problem hiding this comment.
Thanks! I have updated the code a bit to already add openIdConnect as an option, without default implementation.
@RobbeSneyders feel free to review, I've kept the "other" custom scheme/type options even though the types allowed are limited, but didn't see much harm in keeping them, as new security types should then also be possible to be provided by the user
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow definition of new auth types (not just schemes) to be passed in to security_map
This is particularly motivated by wanting to support OpenIDConnect auth type, but was running into an error as it couldn't find the
schemekey (as it's not permitted in the schema by the openAPI validator).The docs imply that you should be able to implement a custom scheme for this, instead I would get a
KeyError.Changes proposed in this pull request:
parse_security_schemesto allow the detection of auth types, not just schemes.