Split parsing from validation completely #1934
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During the refactoring for Connexion 3, we deduplicated all
coerce_type
calls during the refactoring and moved them into theuri_parser
so it is done in a single place. When looking into #1931 however, I noticed we are still using theuri_parser
from more places than we should.This PR centralizes the parsing further into the
ConnexionRequest
class. During validation, we now instantiate aConnexionRequest
instead of a StarletteRequest
, and leverage it instead of calling theuri_parser
directly.I split the parsing and validation in the tests so they can be tested in isolation.