Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update build doc for new spec-parser options #1186

Merged
merged 10 commits into from
Feb 24, 2025
Merged

Update build doc for new spec-parser options #1186

merged 10 commits into from
Feb 24, 2025

Conversation

bact
Copy link
Collaborator

@bact bact commented Feb 18, 2025 •
edited
Loading

@bact bact added the doc improvement Area where the project documentation needs improvement label Feb 18, 2025
@bact
Fix link
2898e1e 
Signed-off-by: Arthit Suriyawongkul <[email protected]>
@bact bact requested a review from zvr February 18, 2025 15:23
bact added 3 commits February 19, 2025 07:30
@bact
Put long command into multiple lines
a212b8f 
Signed-off-by: Arthit Suriyawongkul <[email protected]>
@bact
Update header
aa42b9c 
Signed-off-by: Arthit Suriyawongkul <[email protected]>
@bact
Add table of contents
0f93d7c 
Signed-off-by: Arthit Suriyawongkul <[email protected]>
@bact bact mentioned this pull request Feb 19, 2025
Open
@bact bact requested a review from goneall February 20, 2025 02:39
goneall
goneall approved these changes Feb 20, 2025
View reviewed changes
Copy link
Member

@goneall goneall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly reviewed for the documentation - I'll leave it to @zvr to review the specific spec-parser options.

zvr
zvr requested changes Feb 20, 2025
View reviewed changes
Copy link
Member

@zvr zvr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only took a look at the changes.

bact and others added 5 commits February 21, 2025 08:46
@bact @zvr
Update build.md
490d241 
Co-authored-by: Alexios Zavras (zvr) <[email protected]>
Signed-off-by: Arthit Suriyawongkul <[email protected]>
@bact
Remove RDF generation part
4d4f0b6 
RDF generation and review can be in the spdx-3-model repo instead

Signed-off-by: Arthit Suriyawongkul <[email protected]>
@bact
Remove --force
7317cde 
Signed-off-by: Arthit Suriyawongkul <[email protected]>
@bact
Update build.md
3379378 
Signed-off-by: Arthit Suriyawongkul <[email protected]>
@bact
Remove SPDX-FileCopyrightText metadata
3ff6fcd 
Signed-off-by: Arthit Suriyawongkul <[email protected]>
@bact bact requested a review from zvr February 21, 2025 02:37
@bact bact merged commit 4b2f9d4 into spdx:develop Feb 24, 2025
2 checks passed
@bact
Copy link
Collaborator Author

bact commented Feb 24, 2025

The build instructions here are applied to the publication workflow in PR #1164 and #1183

@bact bact deleted the update-build-doc branch February 24, 2025 21:52
bact added a commit to bact/spdx-spec that referenced this pull request Feb 24, 2025
@bact
Update build.md with new spec-parser options
dc93446 
Same changes as in spdx#1186

Signed-off-by: Arthit Suriyawongkul <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zvr zvr zvr approved these changes

@goneall goneall goneall approved these changes

Assignees
No one assigned
Labels
doc improvement Area where the project documentation needs improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update build.md to match new options in spec-parser
3 participants
@bact @zvr @goneall