-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add dependency on read-writer queue #14
Comments
I'll try to file a pr for this, but I'm wondering how to handle versioning of the library |
@Origin-yy I think we can fetch the tag corresponding to the lastest release. You can also compare it against the version we included in our code to check if there are any potential incompatibilities. |
I am new to open source development, but I'm eager to learn and contribute to resolving this issue. |
@Mac16661 I recommend starting with looking at CMake FetchModule - we want to use that to add the library as a component :-) |
Hey @mcopik , can I work on this issue? |
@nicolo-mn Sure, I will appreciate any help! Can you test locally the code from closed PR #41 and see if it works for you? |
We should add readerwriterqueue as a proper dependency in the CMake build. Furthermore, we want to fetch and build
Pistache
to avoid the trouble of forcing users to install it manually.The text was updated successfully, but these errors were encountered: