Used valid FORTRAN test program for a couple frontend tests + Made floatlit2string() convert the FORTRAN real literal strings into python floats.
#1733
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
passes under `gfortran -Wall`). This breaks some of the tests, so add fix for them too. `test_fortran_frontend_loop1()` still has an invalid test program, but the nearest valid one breaks for a different reason, and will be fixed later.
acalotoiu
approved these changes
Nov 6, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 10, 2024
…test program. (#1736) A follow up of #1733 that took a bit longer to figure out. This change breaks the test on `multi_sdfg` branch, but there the front-end is doing something additionally wrong (it somehow promotes `nclv` into a input parameter for the whole program) -- but it will even take longer to figure out why.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace some of the invalid fortran test programs with valid ones (that passes under
gfortran -Wall). This breaks some of the tests, so add fix for them too.test_fortran_frontend_loop1()still has an invalid test program, but the nearest valid one breaks for a different reason, and will be fixed later.