Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix type inference and code generation for typeclasses and numpy types #1725

Merged
merged 8 commits into from
Nov 8, 2024
Merged

Fix type inference and code generation for typeclasses and numpy types #1725

merged 8 commits into from
Nov 8, 2024

Conversation

tbennun
Copy link
Collaborator

@tbennun tbennun commented Nov 3, 2024

Fixes #1710
Supersedes #1721

@tbennun tbennun requested a review from pratyai November 3, 2024 04:29
@tbennun tbennun mentioned this pull request Nov 3, 2024
Closed
@tbennun tbennun added this to the 1.0 milestone Nov 3, 2024
@tbennun tbennun mentioned this pull request Nov 3, 2024
Closed
@tbennun tbennun removed the request for review from pratyai November 3, 2024 04:32
@tbennun tbennun marked this pull request as draft November 3, 2024 04:32
@tbennun tbennun added the no-ci Do not run any CI or actions for this PR label Nov 3, 2024
@tbennun tbennun removed the no-ci Do not run any CI or actions for this PR label Nov 3, 2024
@pratyai
Copy link
Collaborator

pratyai commented Nov 4, 2024

LGTM.
Thanks a lot for the fix! I can confirm that the patch solves my bug (I find it a bit difficult to track down how the patch affects the transform, but I think that's alright).

@tbennun
Copy link
Collaborator Author

tbennun commented Nov 4, 2024

LGTM. Thanks a lot for the fix! I can confirm that the patch solves my bug (I find it a bit difficult to track down how the patch affects the transform, but I think that's alright).

Specifically, it's this code: https://github.com/spcl/dace/pull/1725/files#diff-1081d65d9e2d7faf4c58d18c8652e775fb685d35ae6d4bf2e1f1234429210126L37

It would return the numpy type instead of the typeclass

@tbennun tbennun marked this pull request as ready for review November 8, 2024 03:30
@tbennun tbennun requested review from pratyai and phschaad November 8, 2024 03:31
phschaad
phschaad approved these changes Nov 8, 2024
View reviewed changes
Copy link
Collaborator

@phschaad phschaad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@phschaad phschaad added this pull request to the merge queue Nov 8, 2024
Merged via the queue into main with commit d61122d Nov 8, 2024
10 checks passed
@phschaad phschaad deleted the fix-dde-dtypes branch November 8, 2024 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phschaad phschaad phschaad approved these changes

@pratyai pratyai Awaiting requested review from pratyai

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.0
Development

Successfully merging this pull request may close these issues.

Dead Dataflow Elimination type hints do not work with all types
3 participants
@tbennun @pratyai @phschaad